-
Notifications
You must be signed in to change notification settings - Fork 120
save_trajs support for fragmented data source #1514
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #1514 +/- ##
=======================================
Coverage 92.03% 92.04%
=======================================
Files 229 229
Lines 26804 26830 +26
=======================================
+ Hits 24670 24695 +25
- Misses 2134 2135 +1
Continue to review full report at Codecov.
|
The test failure is unrelated to this set of changes, following up with another PR |
used_data = used_frames / float(it.n_frames_total()) * 100.0 | ||
raise NotConvergedWarning("Used data for centers: %.2f%%" % used_data) | ||
except Exception as e: | ||
if 'MaxCentersReachedException' in e.__class__.__name__: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this exception be caught explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the next deeptime release yes :) right now it's set up a bit unfortunate with the rmsd metric so i can only catch it implicitly.
see markovmodel/pyemma_tutorials#198