Fixed socket leak in I2PInterface

markqvist · Jun 11, 2022 · d7262c7 · d7262c7
1 parent d9a0214
commit d7262c7
Showing 1 changed file with 45 additions and 6 deletions.
diff --git a/RNS/Interfaces/I2PInterface.py b/RNS/Interfaces/I2PInterface.py
@@ -107,8 +107,13 @@ def start(self):
 
 
     def stop(self):
-        for task in asyncio.Task.all_tasks(loop=self.loop):
-            task.cancel()
+        for i2ptunnel in self.i2plib_tunnels:
+            if hasattr(i2ptunnel, "stop") and callable(i2ptunnel.stop):
+                i2ptunnel.stop()
+
+        if hasattr(asyncio.Task, "all_tasks") and callable(asyncio.Task.all_tasks):
+            for task in asyncio.Task.all_tasks(loop=self.loop):
+                task.cancel()
 
         self.loop.stop()
 
@@ -182,25 +187,35 @@ async def tunnel_up():
             else:
                 i2ptunnel = self.i2plib_tunnels[i2p_destination]
                 if hasattr(i2ptunnel, "status"):
-                    # TODO: Remove
-                    # RNS.log(str(i2ptunnel.status))
                     i2p_exception = i2ptunnel.status["exception"]
 
                     if i2ptunnel.status["setup_ran"] == False:
                         RNS.log(str(self)+" I2P tunnel setup did not complete", RNS.LOG_ERROR)
+
+                        if hasattr(i2ptunnel, "stop") and callable(i2ptunnel.stop):
+                            i2ptunnel.stop()
                         return False
 
                     elif i2p_exception != None:
                         RNS.log(str(self)+" An error ocurred while setting up I2P tunnel. The contained exception was: "+str(i2p_exception), RNS.LOG_ERROR)
                         RNS.log("Resetting I2P tunnel", RNS.LOG_ERROR)
+
+                        if hasattr(i2ptunnel, "stop") and callable(i2ptunnel.stop):
+                            i2ptunnel.stop()
                         return False
 
                     elif i2ptunnel.status["setup_failed"] == True:
                         RNS.log(str(self)+" Unspecified I2P tunnel setup error, resetting I2P tunnel", RNS.LOG_ERROR)
+
+                        if hasattr(i2ptunnel, "stop") and callable(i2ptunnel.stop):
+                            i2ptunnel.stop()
                         return False
 
                 else:
                     RNS.log(str(self)+" Got no status from SAM API, resetting I2P tunnel", RNS.LOG_ERROR)
+
+                    if hasattr(i2ptunnel, "stop") and callable(i2ptunnel.stop):
+                        i2ptunnel.stop()
                     return False
 
             time.sleep(5)
@@ -260,7 +275,6 @@ async def tunnel_up():
                     raise e
 
             else:
-
                 i2ptunnel = self.i2plib_tunnels[i2p_b32]
                 if hasattr(i2ptunnel, "status"):
                     # TODO: Remove
@@ -269,19 +283,31 @@ async def tunnel_up():
 
                     if i2ptunnel.status["setup_ran"] == False:
                         RNS.log(str(self)+" I2P tunnel setup did not complete", RNS.LOG_ERROR)
+
+                        if hasattr(i2ptunnel, "stop") and callable(i2ptunnel.stop):
+                            i2ptunnel.stop()
                         return False
 
                     elif i2p_exception != None:
                         RNS.log(str(self)+" An error ocurred while setting up I2P tunnel. The contained exception was: "+str(i2p_exception), RNS.LOG_ERROR)
                         RNS.log("Resetting I2P tunnel", RNS.LOG_ERROR)
+
+                        if hasattr(i2ptunnel, "stop") and callable(i2ptunnel.stop):
+                            i2ptunnel.stop()
                         return False
 
                     elif i2ptunnel.status["setup_failed"] == True:
                         RNS.log(str(self)+" Unspecified I2P tunnel setup error, resetting I2P tunnel", RNS.LOG_ERROR)
+
+                        if hasattr(i2ptunnel, "stop") and callable(i2ptunnel.stop):
+                            i2ptunnel.stop()
                         return False
 
                 else:
                     RNS.log(str(self)+" Got no status from SAM API, resetting I2P tunnel", RNS.LOG_ERROR)
+
+                    if hasattr(i2ptunnel, "stop") and callable(i2ptunnel.stop):
+                        i2ptunnel.stop()
                     return False
 
             time.sleep(5)
@@ -426,7 +452,20 @@ def set_timeouts_osx(self):
             self.socket.setsockopt(socket.IPPROTO_TCP, TCP_KEEPIDLE, int(I2PInterfacePeer.TCP_PROBE_AFTER))
         else:
             self.socket.setsockopt(socket.IPPROTO_TCP, TCP_KEEPIDLE, int(I2PInterfacePeer.I2P_PROBE_AFTER))
-
+
+    def shutdown_socket(self, socket):
+        if callable(socket.close):
+
+            try:
+                socket.shutdown(socket.SHUT_RDWR)
+            except Exception as e:
+                RNS.log("Error while shutting down socket for "+str(self)+": "+str(e))
+
+            try:
+                socket.close()
+            except Exception as e:
+                RNS.log("Error while closing socket for "+str(self)+": "+str(e))    
+
     def detach(self):
         if self.socket != None:
             if hasattr(self.socket, "close"):