fix macos parameter order #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kivy's default for input boxes changed from "text" to "null" in Kivy 2.1.0. Not specifying it disallowed typing using predictive text keyboards such as Gboard or Swiftkey swiping, which was irritating, when you are typing text messages.
Fix for predictive text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, rm needs parameters first, then files, so "rm filename -r" won't work
I separated the cp, because the behavior of cp for symlinks is different and it does not copy the symlink well. But since we delete the symlink in the next line, it does not matter, I just made the rm not throw the error when it fails (which id does on macos, because the symlink is not copied).
This does not fix the build unfortunately, but it goes a bit further.