-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added emptyText to SelectArrayInput component #10504
base: next
Are you sure you want to change the base?
Conversation
packages/ra-ui-materialui/src/input/SelectArrayInput.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Tamm <[email protected]>
Co-authored-by: Gohar Attiq <[email protected]>
Co-authored-by: Gohar Attiq <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm -1 for this feature. The right UI for clearing a select input is a clear button, not a clear option. MUI has a discussion and instructions for implementing this in user land: |
I agree that it makes more sense a clear button, but I tried to replicate the way it was in |
I understand your reasonning, and it makes sense. However, for new features, we look for the best balance between intuitive DX and good UX. In this case, I think the balance clearly points to a clear button as adornment. |
Problem
Absence of the emptyText property in the SelectArrayInput component #10454
Solution
The empty Text property was added to the component, the emptyText option clears all fields that had been selected
How To Test
It is possible to view the update in the storybook
Additional Checks
master
for a bugfix, ornext
for a featureAlso, please make sure to read the contributing guidelines.