[DNM] Fix tab navigation with react-router >= 6.19 #9476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
commented
Nov 28, 2023
| @@ -36,7 +36,7 @@ export const TabbedFormView = (props: TabbedFormViewProps): ReactElement => { | |||
| ...rest | |||
| } = props; | |||
| const location = useLocation(); | |||
| const resolvedPath = useResolvedPath(''); | |||
| const resolvedPath = useResolvedPath('.'); | |||
There was a problem hiding this comment.
Unfortunately this part doesn't work:
- React-router 6.18 requires
useResolvedPath('.') - While React-router 6.20 requires
useResolvedPath('..')
I can't find a way to make both versions happy with the same code...
I'm open to any suggestions if any, or, you may want to upvote remix-run/react-router#11048 (comment) and remix-run/react-router#11052 (comment) to request for a fix from react-router.
There was a problem hiding this comment.
I suggest we change the package.json to forbid recent react-router versions.
slax57
changed the title
|
Superseded by #9480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9468