FIX TLS in SMTP.py #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rejected for the same reason as the other PR attempting to correct this in this way: this is the most "hack and slash" way possible to correct the problem, which is an underlying problem "up-stream" in Python's standard library. This is a bug with Python, not with Marrow Mailer. This correction, as mentioned previously, suffers the additional deficit (and feature removal) of being able to set diagnostic logging level prior to the connection attempt. If a hostname is provided early, the connection is initiated within |
amcgregor
added
the
meta:rejected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Syntax for TLS host = self.host in TLS SSL Mode for SMTP Connection, Fixes Issues when Using SSL in SMTP