Check execute permission on last directory

Fixes #159
marschall · Sep 22, 2024 · 9016236 · 9016236
1 parent 95ea9b7
commit 9016236
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/main/java/com/github/marschall/memoryfilesystem/MemoryFileSystem.java b/src/main/java/com/github/marschall/memoryfilesystem/MemoryFileSystem.java
@@ -344,6 +344,7 @@ public GetEntryResult value(MemoryDirectory directory) throws IOException {
           MemoryFile file = this.createEntryOnAccess(path, newAttributes, directory, elementPath, creationContext);
           return new GetEntryResult(file);
         } else {
+          directory.checkAccess(AccessMode.EXECUTE);
           MemoryEntry storedEntry = directory.getEntry(key);
           if (storedEntry == null) {
             boolean isCreate = options.contains(CREATE);

diff --git a/src/test/java/com/github/marschall/memoryfilesystem/PosixPermissionMemoryFileSystemTest.java b/src/test/java/com/github/marschall/memoryfilesystem/PosixPermissionMemoryFileSystemTest.java
@@ -352,4 +352,18 @@ void issue138() throws IOException {
     }
   }
 
+  @Test
+  void issue159() throws IOException {
+    FileSystem fileSystem = this.extension.getFileSystem();
+    Path path = fileSystem.getPath("/", "sub1", "sub2", "test.txt");
+    Path parent = path.getParent();
+    FileUtility.createAndSetContents(path, "Hello World");
+    Set<PosixFilePermission> previousPermissions = Files.getPosixFilePermissions(parent);
+    EnumSet<PosixFilePermission> noExecute = EnumSet.copyOf(previousPermissions);
+    noExecute.removeAll(EnumSet.of(PosixFilePermission.GROUP_EXECUTE, PosixFilePermission.OTHERS_EXECUTE, PosixFilePermission.OWNER_EXECUTE));
+    Files.setPosixFilePermissions(parent, noExecute); // removes execute permission
+    assertEquals(noExecute, Files.getPosixFilePermissions(parent));
+    assertThrows(AccessDeniedException.class, () -> Files.readAllBytes(path));
+  }
+
 }