Fix strncmp off-by-one in libumockdev-preload.c #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That fix looks correct, many thanks for spotting! Just the test runs were a complete disaster, apparently a lot has changed in the distros in the last 3 weeks.. I (mostly) fixed that in master. Can you please rebase/force-push your branch, so that the tests can run? Thanks! |
The `"/proc/"` string is of len 6 instead of 5. This was found with a "cstrnfinder" research and I haven't tested this change (more info https://twitter.com/disconnect3d_pl/status/1339757359896408065).
|
@disconnect3d : I took the liberty to rebase your branch (as you allowed edits from maintainers). I also slightly adjusted the commit message. There are still some failures on debian-testing due to issue #115, these are unrelated. |
martinpitt
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
"/proc/"string is of len 6 instead of 5.This was found with a "cstrnfinder" research and I haven't tested this change (more info https://twitter.com/disconnect3d_pl/status/1339757359896408065). Close this PR if this change is incorrect.