Fix should_ properties (#11)

* Parentheses around condition * Yaml typo * Simplified condition --------- Co-authored-by: Martin Smith <[email protected]>
martinsmith1968 · Aug 21, 2024 · b845425 · b845425
1 parent dd8a796
commit b845425
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml
@@ -66,7 +66,7 @@ jobs:
             should_release=true
         elif [[ "${{ github.ref }}" == refs/heads/${{ env.BRANCH_PREFIX_RELEASE_CANDIDATE }}* ]]
         then
-            should_publish=true
+            should_release=true
         fi
 
         echo "should_release=${should_release}" >> $GITHUB_ENV
@@ -103,7 +103,7 @@ jobs:
 
     - name: Show Configuration
       id: show_configuration
-      run: env
+      run: env | sort
 
     outputs:
       assembly_version: ${{ env.assembly_version }}
@@ -194,7 +194,7 @@ jobs:
   ## Generate a Release and Tag in git
   release:
     name: Create GitHub Release
-    if: needs.setup.outputs.should_release == 'true' && success()
+    if: needs.setup.outputs.should_release == 'true'
 
     needs:
       - setup
@@ -238,7 +238,7 @@ jobs:
   ## Publish to NuGet
   publish:
     name: Publish to NuGet
-    if: needs.setup.outputs.should_publish == 'true' && success()
+    if: needs.setup.outputs.should_publish == 'true'
 
     needs:
       - setup