Build warnings and hacked back to static version number

(Fix properly when moved to NET standard and new csproj)
martinsmith1968 · Dec 27, 2019 · afe4348 · afe4348
1 parent a77bd40
commit afe4348
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/DNX.Helpers/DNX.Helpers.nuspec b/DNX.Helpers/DNX.Helpers.nuspec
@@ -5,7 +5,7 @@ https://stackoverflow.com/questions/14797525/differences-between-nuget-packing-a
 <package >
   <metadata>
     <id>DNX.Helpers</id>
-    <version>$version$</version>
+    <version>1.2.2</version>
     <authors>Martin Smith</authors>
     <owners>DNX Solutions Ltd</owners>
     <licenseUrl>https://raw.githubusercontent.com/martinsmith1968/DNX.Helpers/master/licence.txt</licenseUrl>

diff --git a/NuGet.Pack.cmd b/NuGet.Pack.cmd
@@ -16,4 +16,6 @@ CALL SetNuGetServerAPIKey.cmd "%APPNAME%"
 
 IF EXIST *.nupkg DEL *.nupkg
 
+@ECHO ON
 "%NUGETEXE%" pack "%SCRIPTPATH%\%APPNAME%\%APPNAME%.csproj"
+@ECHO OFF
diff --git a/NuGet.Push.cmd b/NuGet.Push.cmd
@@ -18,5 +18,7 @@ CALL SetNuGetServerAPIKey.cmd "%APPNAME%"
 
 FOR %%F IN (*.nupkg) DO (
     ECHO.Pushing: %%~F
+    @ECHO ON
     %NUGETEXE% push "%%~F" -Source "%NUGETSERVERAPIURL%" -ApiKey "%NUGETSERVERAPIKEY%"
+    @ECHO OFF
 )
diff --git a/Test.DNX.Helpers/Strings/StringExtensionsTests.cs b/Test.DNX.Helpers/Strings/StringExtensionsTests.cs
@@ -337,10 +337,6 @@ public bool Test_IsValidNumber_default_culture(string text, string cultureInfoNa
 
                 return result;
             }
-            catch (Exception e)
-            {
-                throw;
-            }
             finally
             {
                 CultureInfo.DefaultThreadCurrentCulture = previousCulture;
-Original file line number
+Diff line change
@@ Expand Up @@
                     return result;
                 }
-                catch (Exception e)
-                {
-                    throw;
-                }
                 finally
                 {
                     CultureInfo.DefaultThreadCurrentCulture = previousCulture;
@@ Expand Down @@