Fix incorrect expected connection request packet length in error message #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Bechard <[email protected]>
|
@SirLynix for review, since you introduced big nonces for connect tokens. |
|
Yes indeed it looks like I forgot to change this line as well, the nonce was 8bytes before my change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection tokens use big nonces, which are 24 bytes. I'm not sure where the hard-coded "8" came from. Maybe stale code, or copy/paste error. The expected length used in the error message should include
NETCODE_CONNECT_TOKEN_NONCE_BYTESto match the if statement.