Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] outdated subcommand lists latest (iOS) version of an app in place of (Mac) version of the app with same name (from same authors) #491

Closed
1 task done
gmerlino opened this issue May 1, 2023 · 8 comments · Fixed by #496
Labels

Comments

@gmerlino
Copy link

gmerlino commented May 1, 2023

Your Environment

  • mas version: 1.8.6
  • macOS version (system_profiler SPSoftwareDataType -detailLevel mini): 13.3.1 (22E261)

mas Install Method

  • brew install mas (homebrew-core)
  • [] mas-cli/tap
  • [] .pkg installer from releases
  • [] Built from source
    • Fork/branch: ? (e.g. mas-cli/main)
    • Xcode version: 10.?

Describe the Bug

iOS app versions (mistakenly) being included (and compared) when checking outdated (Mac) apps

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected Behavior

mas outdated should not produce as output:

967805235 Paste (3.1.9 -> 3.2)

considering there exists no 3.2 version (yet) of the Paste app on the (Mac) App Store.

Actual Behavior

At each invocation of

mas upgrade

Paste (version 3.1.9) will be (re)installed.
By checking with:

mas outdated

I get the following output (before, and as well after, invoking upgrade):

967805235 Paste (3.1.9 -> 3.2)

so I may guess this (unexpected) output to point right at the root cause.

In particular, there is no 3.2 release (yet), as I guess MAS is (mistakenly) checking the versions of the iOS flavour of the same App, as the iOS latest version of the app in the store indeed is at 3.2, and conflating/comparing the versions both from the Mac side and the iOS side. In this case, iOS version (3.2) would be the latest, compared to Mac version (3.1.9) and naturally take precedence, hence being listed among "outdated" apps.

Screenshots, Terminal Output

If applicable, add screenshots to help explain your problem.

$ mas command
...

Additional Context

Add any other context about the problem here.
Did it work in a previous version?

@timweston
Copy link

I'm having the same problem with mas. mas outdated shows new versions available, but the new versions are actually the latest iOS app version. Then, as a result, mas upgrade continually tries to upgrade the apps to the new versions.

mas outdated:
mas outdated

CardPointers in Mac App Store:
CardPointers for Mac

CardPointers in iOS App Store (the "new" version that mas says is available)
CardPointers for iOS

1Blocker in Mac App Store:
1Blocker for Mac

1Blocker in iOS App Store (the "new" version that mas says is available)
1Blocker for iOS

@ming-hao-xu
Copy link

Same issue on app 'flow'

1423210932 Flow (2.12.0 -> 3.0.2)

@oschrenk
Copy link

Same for

1115567069 Health Auto Export (2.1.4 -> 7.0.9)
905953485 NordVPN (8.8.3 -> 8.13.0)
1423210932 Flow (2.13.0 -> 3.1.1)

@phatblat
Copy link
Member

I've published a build with a potential fix (#505) for this on the releases page:
https://github.com/mas-cli/mas/releases/tag/v1.8.7-beta.1

Could I get some volunteers to install the .pkg attached to that release to see if this resolves any of these issues?

@gmerlino
Copy link
Author

gmerlino commented Nov 29, 2023

The beta solves the issue (#491) for all (8) the (wrong iOS) packages but one: the only holdout now is Testflight.

@phatblat
Copy link
Member

@gmerlino Can you share your mas outdated output? I want to investigate the specific versions of Testflight in the iTunes API.

@gmerlino
Copy link
Author

@gmerlino Can you share your mas outdated output? I want to investigate the specific versions of Testflight in the iTunes API.

899247664 TestFlight (3.3.0 -> 3.4.3)

@suhaybu
Copy link

suhaybu commented Dec 11, 2023

Tried using mas 1.8.7-beta.1 but the issue still persists.

Log:

suhayb@iPhone-179 ~ % mas version
1.8.7-beta.1
suhayb@iPhone-179 ~ % mas outdated
1423210932 Flow (2.13.2 -> 3.2.5)
suhayb@iPhone-179 ~ % mas upgrade
Upgrading 1 outdated application:
Flow (2.13.2) -> (3.2.5)
==> Downloading Flow - Focus & Pomodoro Timer
==> Installed Flow - Focus & Pomodoro Timer
suhayb@iPhone-179 ~ % mas outdated
1423210932 Flow (2.13.2 -> 3.2.5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants