Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 Release 1.8.7 #506

Open
wants to merge 166 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 135 commits
Commits
Show all changes
166 commits
Select commit Hold shift + click to select a range
436c3a2
🔍 Search for compatible iPad and iPhone apps
chris-araman May 13, 2021
ef28bc9
🍺 Update mas homebrew formula (1.8.6)
phatblat Nov 25, 2023
f1276da
🍺 Update mas-tap homebrew formula (1.8.6)
phatblat Nov 25, 2023
742e054
🔨 Add support for sonoma & ventura to bottle script
phatblat Nov 25, 2023
f3e681a
🔖 Version 1.8.7-alpha.1
phatblat Nov 25, 2023
8076c66
👌🏻 Fix untested OS branches in bottle script
phatblat Nov 25, 2023
b8dc5ff
🔥 Remove dup bottles target
phatblat Nov 25, 2023
40d3cfd
🔨 Rename MAS_VERSION variable
phatblat Nov 25, 2023
a12d232
🥅 Swalloer error if trash fails
phatblat Nov 25, 2023
2a02cee
🔨 Add sonoma & ventura to bottle script
phatblat Nov 25, 2023
bcd2411
🔥 Remove duplicate monterey bottle reference
phatblat Nov 25, 2023
a143845
🔨 Use brew --prefix
phatblat Nov 25, 2023
96ff7ec
🔨 Install universal binary
phatblat Nov 29, 2023
f162f6a
🔀 Fix merge mistake
phatblat Feb 18, 2024
666e505
🎨 Format bash scripts
phatblat Feb 18, 2024
cf2d8d6
🔧 Configure .actrc
phatblat Feb 18, 2024
e20b14a
🚚 Rename pr-checks workflow
phatblat Feb 18, 2024
5b2994d
⬆️ danger-swift (3.18.0)
phatblat Feb 18, 2024
b7aa6b7
🔧 Configure .actrc
phatblat Feb 18, 2024
8d735e4
➕ act (0.2.59)
phatblat Feb 18, 2024
f7152f2
🥅 Handle version script errors when invoked by act
phatblat Feb 18, 2024
65b4343
🔥 Remove unused travis-ci config
phatblat Feb 18, 2024
fe5642f
✨ Add initial release workflow
phatblat Feb 18, 2024
3a0fe2f
🔧 Configure yamllint
phatblat Feb 18, 2024
1aa7aee
➕ yamllint (1.35.1)
phatblat Feb 18, 2024
0806fba
➕ prettier (3.2.5)
phatblat Feb 18, 2024
8eab75e
🎨 Format YAML files
phatblat Feb 18, 2024
08697a8
👢 Use mise to install tools
phatblat Feb 18, 2024
7415f73
🔨 Include YAML in lint, format scripts
phatblat Feb 18, 2024
30ba6ad
🔥 Remove unused hound config
phatblat Feb 18, 2024
ec9fa6e
⏲️ TEMP: Trigger release workflow on push for testing
phatblat Feb 18, 2024
973b328
🔊 Enable mise verbose output
phatblat Feb 18, 2024
d3e8a3b
🔧 Enable experimental mise features
phatblat Feb 18, 2024
bbbbb01
🔇 Hide output from git describe
phatblat Feb 18, 2024
4d5816c
🔊 Log mise config
phatblat Feb 18, 2024
ebfd624
🔥 Remove experimental mise subcommands
phatblat Feb 18, 2024
2c39d30
🔇 Remove extra chars from stdout
phatblat Feb 19, 2024
74f2334
👷🏻‍♀️ Build mas package and bottles
phatblat Feb 19, 2024
81ed7d0
👷🏻‍♂️ Upload bottles
phatblat Feb 19, 2024
9298dae
👷🏻‍♀️ Build bottles before upload
phatblat Feb 19, 2024
2d46b71
🔨 Organize make targets
phatblat Feb 19, 2024
9088bad
🎯 Rename update-headers target
phatblat Feb 19, 2024
b1fe872
⬆️ Update swift dependencies
phatblat Feb 19, 2024
7a39573
🎯 Rename package-install target
phatblat Feb 19, 2024
bb985c8
🔥 Remove incomplete brew_update script
phatblat Feb 19, 2024
4a9626d
🚧 brew_formula_update
phatblat Feb 19, 2024
e5b471d
♻️ Set CORE_FORMULA_PATH using brew —repository
phatblat Mar 4, 2024
f76c19f
🌍 Enable HOMEBREW_NO_INSTALL_FROM_API
phatblat Mar 4, 2024
4ef176c
🩹 Remove extra end paren from CURRENT_OS_VERSION_MINOR
phatblat Mar 9, 2024
5f36926
🔨 Ensure a clean tap of core
phatblat Mar 9, 2024
405b8d6
👽 Update MAS_FORMULA_PATH in core
phatblat Mar 9, 2024
124ad1e
👔 Tap core only when missing
phatblat Mar 9, 2024
1d04626
👷🏻 Add brew_formula_update to release workflow
phatblat Mar 9, 2024
d932b8c
🔨 Fix core tap detection
phatblat Mar 9, 2024
a886830
🔨 Add brew_build_interactive script
phatblat Mar 9, 2024
80c85f5
👀 Add Package.swift
phatblat Mar 9, 2024
67e6784
🔨 Add version_bump script
phatblat Mar 9, 2024
e753f23
🔊 Log release event details
phatblat Mar 9, 2024
cc07b31
🔊 Log dry vs wet run
phatblat Mar 9, 2024
e30cacb
🚩 Default DRY_RUN to true
phatblat Mar 9, 2024
d321c2b
🔧 Run bash outside Rosetta 2
phatblat Mar 9, 2024
72042aa
⬆️ act (0.2.60)
phatblat Mar 9, 2024
6a80ac3
➕ sd (1.0.0)
phatblat Mar 10, 2024
a0e9417
🔨 Write new version in brew formulae
phatblat Mar 10, 2024
da8142d
🔨 Trigger version_bump, create branch, commit in brew_formula_update
phatblat Mar 10, 2024
1fd27c1
👷🏻‍♂️ Derive MAS_VERSION from release, pass to script
phatblat Mar 10, 2024
11734da
👷🏻‍♀️ Create PR on mas
phatblat Mar 10, 2024
d84dd58
🚩 Add dry run support to brew_formula_update
phatblat Mar 10, 2024
76c8314
🚩 Pass DRY_RUN to brew_formula_update
phatblat Mar 10, 2024
6c65f4e
👷🏻‍♂️ Move homebrew/core update before mas tap
phatblat Mar 10, 2024
fc4ffae
📌 Pin MAS_VERSION to v1.8.7-beta.1 in release workflow
phatblat Mar 10, 2024
b8803ba
🔨 Use real revision, write brew formula before testing
phatblat Mar 10, 2024
b6fa1c8
🔨 Validate core formula
phatblat Mar 10, 2024
9a094b1
🔨 Revert core formula after testing
phatblat Mar 10, 2024
6f658ed
♻️ Move defaults to workflow level
phatblat Mar 10, 2024
30a4987
♻️ Move env to workflow level
phatblat Mar 10, 2024
87a0074
👷🏻‍♀️ Update GITHUB_ENV
phatblat Mar 10, 2024
c0950b1
♻️ Split workflow into 4 jobs
phatblat Mar 11, 2024
b49d9db
🔥 Remove tap logic from brew_core_update
phatblat Mar 11, 2024
20ba23e
🔥 Remove core logic from brew_tap_update
phatblat Mar 11, 2024
37cf311
🔨 Invoke bottle script from brew_tap_update
phatblat Mar 11, 2024
1b7d6fd
🔨 Add frozen (-f) option to bootstrap script
phatblat Mar 30, 2024
eb353fa
🚚 Rename start job
phatblat Mar 30, 2024
246636c
🔥 Remove Finder open command from bottle script
phatblat Mar 30, 2024
9ae7665
🔇 Remove getops logging
phatblat Mar 30, 2024
283ddb6
🔧 Set json indent size to 2
phatblat Mar 31, 2024
13514f0
🤡 Add mock release event.json
phatblat Mar 31, 2024
a6d747c
🔒 Update brew lockfile
phatblat Mar 31, 2024
700a1e1
➕ python (3.11)
phatblat Mar 31, 2024
28dcc76
🚨 Resolve linter errors
phatblat Mar 31, 2024
87fd066
🚨 Remove unused dry_run variable from brew_tap_update script
phatblat Mar 31, 2024
34ab84f
🚨 Format scripts and yaml
phatblat Mar 31, 2024
388358a
⬆️ python (3.12.2)
phatblat Mar 31, 2024
08d64b3
🔥 Remove lint and tools from CI
phatblat Mar 31, 2024
f79165e
🚀 Replace upload-artifact action with gh CLI command
phatblat Mar 31, 2024
557b561
🔥 Remove push hook and env values used for testing workflow
phatblat Mar 31, 2024
08c6c98
Merge pull request #510 from mas-cli/gha/release-workflow
phatblat Mar 31, 2024
0c151dd
⏮️ Restore .hound.yml
phatblat Mar 31, 2024
b33f7ab
🚨 Quote variables
phatblat Mar 31, 2024
d306660
🔨 Set PREFIX to /usr/local in install script
phatblat Mar 31, 2024
b227aca
🔊 Log commands in homebrew scripts
phatblat Mar 31, 2024
4c01f14
🔨 Change brew_core_update dry run to only run bump-formula-pr once
phatblat Mar 31, 2024
aa4ce7c
🔥 Remove --commit option
phatblat Mar 31, 2024
442dc96
🙈 Ignore .vscode/
phatblat Jul 29, 2024
9ae9cba
👷🏼‍♂️ Move homebrew-tap before homebrew-core in release workflow
phatblat Jul 29, 2024
7d063d6
Merge branch 'main' into releases/release-1.8.7
phatblat Jul 29, 2024
56a3ffc
👷🏼‍♂️ Update job dependencies
phatblat Jul 29, 2024
78757ab
🔥 Remove bottle step from release workflow
phatblat Jul 29, 2024
76d380d
👷🏼‍♂️ Add version-update job to release workflow
phatblat Jul 30, 2024
bc93e91
🔧 Add RELEASE_BRANCH variable
phatblat Jul 30, 2024
97fa10f
👷🏻‍♀️ Rework and rename prepare-release job
phatblat Jul 30, 2024
5b5ba92
🐛 Fix variable handling using job outputs
phatblat Jul 31, 2024
cfa3c70
🐛 Use script variable syntax
phatblat Jul 31, 2024
8b270a1
👷🏼‍♂️ Add bootstrap to prepare-release job
phatblat Jul 31, 2024
ba97743
🐛 Push branch before opening PR
phatblat Jul 31, 2024
bc88359
🔐 Add GH_TOKEN to steps using gh command
phatblat Jul 31, 2024
0c701cc
👷🏻‍♀️ Checkout release branch in downstream jobs
phatblat Jul 31, 2024
adcad9c
🐛 Remove problematic RELEASE_COMMIT
phatblat Jul 31, 2024
3b5d335
🔧 Disable dry-run in brew_tap_update
phatblat Jul 31, 2024
20f2d3f
🔐 Add GH_TOKEN to tap update step
phatblat Jul 31, 2024
94258ea
👷🏻‍♀️ Push tap branch and add details to PR
phatblat Jul 31, 2024
c00c765
🔐 Add GH_TOKEN to core update step
phatblat Jul 31, 2024
91f7491
🔥 Remove PR creation from brew_core_update
phatblat Jul 31, 2024
53319d9
♻️ Extract PR creation from brew_tap_update script
phatblat Jul 31, 2024
52c96db
♻️ Extract git push from brew_tap_update script
phatblat Jul 31, 2024
0578f0c
♻️ Pull tap git commands up into workflow
phatblat Aug 1, 2024
30aa073
🔐 Add DEPLOY_TOKEN for mas tap PR creation
phatblat Aug 3, 2024
20faba3
👷🏻‍♀️ Checkout mas-cli/homebrew-tap in subdir
phatblat Aug 3, 2024
84e13f9
🔗 Symlink tap to taps dir
phatblat Aug 3, 2024
c073f0a
📂 mkdirs
phatblat Aug 3, 2024
d202441
♻️ Add tap and re-clone with token
phatblat Aug 3, 2024
7603c30
👷🏼‍♂️ Checkout using symlink
phatblat Aug 3, 2024
cb6f17d
🔥 Remove subdirs to get ready for symlink
phatblat Oct 13, 2024
5ea1967
🔊 Log brew taps before/after symlink
phatblat Oct 13, 2024
56a7d95
📎 Symlink before tapping
phatblat Oct 13, 2024
2bcbc27
📎 Fix symlink to local Taps dir
phatblat Oct 20, 2024
aa394e4
🩹 Install formula so we can audit it
phatblat Oct 20, 2024
5b8fed8
🔨 Remove install and enhance audit command
phatblat Oct 26, 2024
a1a9a9d
🚨 Resolve brew style lint offenses
phatblat Oct 26, 2024
635898d
🔨 Change style to use file path
phatblat Oct 26, 2024
3332773
🔊 Echo commands in bottle script
phatblat Oct 26, 2024
7ecbf60
🔨 Update version in root_url
phatblat Oct 26, 2024
64961e7
🔨 Fix root_url replacement syntax
phatblat Oct 26, 2024
8bbf552
🔨 Use MAS_VERSION in root_url
phatblat Oct 26, 2024
e9fcf2b
Merge branch 'main' into upstream/releases/release-1.8.7
rgoldberg Oct 27, 2024
f9ce413
Restore `git describe` check in `version`.
rgoldberg Oct 27, 2024
750930e
Merge branch 'main' into releases/release-1.8.7
phatblat Nov 2, 2024
4a78466
🚚 Update path to Package.swift
phatblat Nov 3, 2024
51d3cdf
🔥 Remove Open release PR step
phatblat Nov 3, 2024
4143139
🗄️ Change git author to masclibot
phatblat Nov 3, 2024
3543335
🚚 Update path to swift release build dir
phatblat Nov 3, 2024
7d0f0a8
🍎 Add macOS sequoia to bottle script
phatblat Nov 3, 2024
73d63a2
🔐 Add HOMEBREW_GITHUB_API_TOKEN
phatblat Nov 3, 2024
513b99d
👷🏻 Restore Build, Test, and Lint name of pr-checks workflow
phatblat Nov 3, 2024
b735bcb
🚚 Restore build-test.yml workflow filename
phatblat Nov 3, 2024
8dd7213
👷🏻 Set name of build-test job
phatblat Nov 3, 2024
b325020
🚨 Wrap long line
phatblat Nov 3, 2024
8eeb204
🚨 Fix YAML list indentation
phatblat Nov 3, 2024
7bde8fa
🔐 Move HOMEBREW_GITHUB_API_TOKEN to mas formula step
phatblat Nov 3, 2024
58f9fbc
🚨 Remove unused vars
phatblat Nov 3, 2024
2ccdb03
🔧 Add PRE_RELEASE var to release workflow
phatblat Nov 3, 2024
d1be1d9
👔 Only run homebrew-core job for real releases
phatblat Nov 3, 2024
a976581
👔 Open tap PR as ready to review instead of draft
phatblat Nov 3, 2024
4405807
🩹 Add pre_release output to start step
phatblat Nov 3, 2024
c314af5
🩹 Remove duplicate v in tap's root_url
phatblat Nov 3, 2024
8617c75
Fix typo in argument check in `script/build`.
rgoldberg Nov 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .actrc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is act used at all?

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
--action-offline-mode
--eventpath .github/event.json
--container-architecture linux/amd64
--log-prefix-job-id
--platform macos-14=-self-hosted
--pull=false
--reuse
--secret-file .secrets
1 change: 1 addition & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ indent_style = tab

# JSON files contain newlines inconsistently
[*.json]
indent_size = 2
insert_final_newline = ignore

# Makefiles always use tabs for indentation
Expand Down
1 change: 1 addition & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates
---
version: 2
updates:
- package-ecosystem: "github-actions"
Expand Down
12 changes: 12 additions & 0 deletions .github/event.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file appears to only be used by act, unless it is somehow used by GitHub (I don't know GitHub config…).

Is this file or act used at all?

Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"inputs": {
"NAME": "Manual Workflow",
"SOME_VALUE": "ABC"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a placeholder value.

},
"release": {
"name": "v1.8.6-beta.1: macOS only test build",
"tag_name": "v1.8.7-beta.1",
"target_commitish": "f8be3e9aaa6c78490277976f17041f2577f5dc21",
"body": "This is a pre-release to facilitate testing for the following fix:\n\n - 🖥️ Only search, outdated and update macOS apps (#505, #496, #491, #336)"
}
Comment on lines +7 to +11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions / commits / descriptions are out of sync, and shouldn't be stored in a file in the repo.

Is this file necessary?

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add trailing newline.

Suggested change
}
}

11 changes: 6 additions & 5 deletions .github/release.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
# https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
---
changelog:
categories:
- title: '🚀 Features'
- title: "🚀 Features"
labels:
- '🆕 feature request'
- title: '🐛 Bug Fixes'
- "🆕 feature request"
- title: "🐛 Bug Fixes"
labels:
- '🐛 bug'
- "🐛 bug"
- title: Changes
labels:
- '*'
- "*"
53 changes: 0 additions & 53 deletions .github/workflows/build-test.yml

This file was deleted.

26 changes: 15 additions & 11 deletions .github/workflows/danger.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
name: Danger
#
# .github/workflows/danger.yml
#
# https://docs.github.com/en/actions/reference/environment-variables#default-environment-variables
---
name: danger
on:
pull_request:
branches: [ main ]
branches: [main]
jobs:
danger:
name: Danger
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Danger
# https://github.com/orgs/danger/packages/container/package/danger-swift
uses: docker://ghcr.io/danger/danger-swift:3.12.3
with:
args: --failOnErrors --no-publish-check
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/checkout@v4
- name: Danger
# https://github.com/orgs/danger/packages/container/package/danger-swift
uses: docker://ghcr.io/danger/danger-swift:3.18.0
with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade dependency.

Suggested change
uses: docker://ghcr.io/danger/danger-swift:3.18.0
uses: docker://ghcr.io/danger/danger-swift:3.20.2

args: --failOnErrors --no-publish-check
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
35 changes: 35 additions & 0 deletions .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#
# .github/workflows/pr-checks.yml
#
# https://docs.github.com/en/actions/reference/environment-variables#default-environment-variables
---
name: pr-checks
on:
pull_request:
branches: [main]
push:
branches: [main]
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
jobs:
build-test:
runs-on: macos-14
defaults:
run:
# Prefixes all `run` commands with the following command to force them to run outside Rosetta.
# https://github.com/actions/runner/issues/805#issuecomment-942784948
# https://github.com/rolpdog/cffi-mirror/blob/release-1.15/.github/workflows/ci.yaml#L81-L141
# https://github.com/actions/virtual-environments/issues/2187#issuecomment-790507204
shell: arch -arm64 bash --noprofile --norc -eo pipefail {0}
steps:
- uses: actions/checkout@v4
with:
# A fetch-depth of 0 includes all history and tags for script/version
fetch-depth: 0
- name: Bootstrap
run: script/bootstrap -f
- name: Build
run: script/build
- name: Test
run: script/test
Loading
Loading