Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional linting / cleanup code #593

Merged
merged 20 commits into from
Oct 23, 2024
Merged

Additional linting / cleanup code #593

merged 20 commits into from
Oct 23, 2024

Commits on Oct 23, 2024

  1. Fix search & uninstall tests. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c289262 View commit details
    Browse the repository at this point in the history

  2. Improve style.md. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    57da9e0 View commit details
    Browse the repository at this point in the history

  3. Cleanup code. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    3d9ea97 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary generics. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a100f3a View commit details
    Browse the repository at this point in the history

  5. Improve DocC. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    3eaffa5 View commit details
    Browse the repository at this point in the history

  6. Improve spacing. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    71fbe2e View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary else blocks. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d7074db View commit details
    Browse the repository at this point in the history

  8. Use isEmpty / beEmpty(). 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    06a347c View commit details
    Browse the repository at this point in the history

  9. Use Self. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e927466 View commit details
    Browse the repository at this point in the history

  10. Fix class names. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    490ee2d View commit details
    Browse the repository at this point in the history

  11. Improve access control. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    586de07 View commit details
    Browse the repository at this point in the history

  12. Improve parameter names. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2af2a42 View commit details
    Browse the repository at this point in the history

  13. Reorder elements. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    3a6d672 View commit details
    Browse the repository at this point in the history

  14. Comment that catch ignores error. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    65218ef View commit details
    Browse the repository at this point in the history

  15. Improve error output. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    fcf8ba2 View commit details
    Browse the repository at this point in the history

  16. Eliminate magic numbers. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ee28af6 View commit details
    Browse the repository at this point in the history

  17. Remove unnecessary variable type. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    87aaba5 View commit details
    Browse the repository at this point in the history

  18. Improve unwrapping. 

    Cleanup code.

Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2edd218 View commit details
    Browse the repository at this point in the history

  19. Improve lint configurations. 

    Partial mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    4d4dd02 View commit details
    Browse the repository at this point in the history

  20. SwiftLint 

    opt_in_rules:
- all

Resolve mas-cli#592

Signed-off-by: Ross Goldberg <[email protected]>
    @rgoldberg
    rgoldberg committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c36a797 View commit details
    Browse the repository at this point in the history