Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rules rewrite to version v1 #70

Merged
merged 139 commits into from
Nov 20, 2024
Merged

feat: rules rewrite to version v1 #70

merged 139 commits into from
Nov 20, 2024

Conversation

danigar
Copy link
Contributor

@danigar danigar commented Jan 5, 2024 •
edited
Loading

Major rewrite and refactor of the rules. Add bzlmod and rules_oci support.

Add new features to existent rules and implement new ones:

  • Support a dictionary of values to substitute in helm charts
  • Create helm charts without specifying chart src files
  • helm_pull repository rule
  • helm_lint rule
  • helm_uninstall rule
  • Publish helm packages to oci and non-oci registries

Fix several issues:

  • Builds reproducibility
  • How stamp values are propagated to rules
  • Some minor issues

Adds Bzlmod support
rules_oci support (rules_docker are still supported)
Rewrite all the docs using stardoc
*Improve CI and release process
*Publish the rules to the bazel central registry

All the changes should be retrocompatible and the APIS remains the same. Some rule attributes have been marked as deprecated but are still supported.

danigar and others added 30 commits October 26, 2022 15:42
@danigar
feat: support gcp artifact registry as repo for pushing helm charts
0d8ed6b
@danigar
fix: helpers load import
9fb9cab
@danigar
fix: toolchain reference
ac35950
@danigar
fix: add gcloud toolchains
6d06368
@danigar
fix: reference to masmovil_bazel_rules workspace
cf0050d
@danigar
fix: use helm toolchain tool as binary
e7d51af
@danigar
Revert "fix: use helm toolchain tool as binary"
d437e44 
This reverts commit e7d51af.
@danigar
fix: helm toolchain
8a4432a
@danigar
Revert "fix: helm toolchain"
2463f1f 
This reverts commit 8a4432a.
@danigar
fix: helm 3 binary path on helm push rule
90700b9
@danigar
fix: import wrong toolchain name
2a708d9
@danigar
upgrade helm to version 3.8
30580a2
@nickdecooman @danigar
Replace @bazel_tools//platforms with @platforms//os (#59)
a1600a8 
Context: bazelbuild/bazel#8622
@chickenandpork @danigar
Update sops to 3.7.3, splitting arm64/amd64 versions for linux/darwin…
618bbf6 
…. Permits sops_decrypt() on M2 Mac (#57)
@danigar
feat: update sops
6f42850
@danigar
fix: missing platform os in gcloud toolchain template
834b3d1
@danigar
fix: typo
15a967e
@danigar
feat: enable oci_image rules support and bazelmod
765e30d
@danigar
feat: enable bazel.module file
dd78e1d
@danigar
feat: support custom bazelrc.user config
5c136e5
@danigar
feat(helm_chart): support extracting image digest from oci_image rules
329cede
@danigar
fix: module.bazel declaration
ab955b4 
Do not load repositories macro from module.bazel file
@danigar
feat: rename module name from com_github_masmovil_bazel_rules to masm…
45aa7de 
…ovil_bazel_rules
@danigar
feat: enable bazel dependencies using bzlmod
22ee7a3
@danigar
feat: refactor helm toolchains to be used as a bzlmod extension
4bc21f7
@danigar
feat: reimplement helm package bazel rule
605f0de
@danigar
chore: move helm rules to private dir under helm directory
6c64384
@danigar
feat: support registering helm toolchains via repo rule invokation in…
38a15cf 
…stead of extension
@danigar
feat: remove yq toolchain dependency in favor of aspect_lib toolchain
61e23d1
@danigar
fix: do not use helm out name for helm toolchain
ad879a0
@danigar danigar marked this pull request as ready for review November 19, 2024 13:46
@danigar danigar changed the base branch from master to v1-test November 19, 2024 13:47
@danigar danigar changed the base branch from v1-test to master November 19, 2024 13:47
danigar added 21 commits November 19, 2024 14:51
@danigar
fix: remove sha256 attr from helm pull rule
3cf4168
@danigar
feat: remove possible BUILD files in chart downlad and expose chart i…
8054dc4 
…nfo using dict
@danigar
Merge branch 'master' of github.com:masmovil/bazel-rules into v1
e86c5cc
@danigar
feat(helm-release): avoid adding namespace flag to helm release if no…
e9676dc 
… namespace or namespace dep is provided
@danigar
fix(helm-release): typo with quotes escape
c65467e
@danigar
fix(gcs_upload): modify subpackage visibility of gcs_upload private f…
efe741a 
…older
@danigar
test: comment out deprecated helm_pull test
5ce4912
@danigar
doc(helm_release): update md docs for namespace attribute
1a47ba7
@danigar
fix: remove tgz go deps
9648fee
@danigar
ci: execute unit tests using ci config
ad7f42e
@danigar
doc: disable write_source_files tests
8dc11e4
@danigar
fix(docs): use right import of stardoc rule
4371c6f
@danigar
docs: update docs generation using new stardoc version
a83c076
@danigar
fix: load yq toolchains
53eccca
@danigar
docs: recover docs generated with stardoc v0.6
5abadc2
@danigar
chore: remove legacy workspace file
28bb4d9
@danigar
chore: enable bzlmod by default
0db4568
@danigar
chore: add bzlmod lockfile changes
0b2c15c
@danigar
chore: add empty workspace file
cd6d2ae
@danigar
docs: add contribute title to main docs
79ba6c1
@danigar
chore: change module.bazel version to v1
f447ce9
@danigar danigar merged commit d27def2 into master Nov 20, 2024
1 check passed
@danigar danigar deleted the v1 branch November 20, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danigar @borg286 @nickdecooman @chickenandpork