Speculative execution support #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-zinger
previously approved these changes
Mar 1, 2022
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Mar 1, 2022
2249: Speculative execution support r=damip a=damip # Intro This is a rewrite of the execution system following the spec we already agreed upon, as well as good practices and with the big refactoring constraints in mind. # Goals * [x] enable speculative execution * [x] get ready for ledger unification # Practices * [x] no async because it's not needed * [x] short functions (max 50 lines of code) * [x] no panics, unless described * crates split between worker and exports * [x] execution * [x] ledger: it will be refactored for on-disk storage, we will split it then => #2342 * thorough documentation * [x] function docs * [x] algorithm description * [x] file-level documentation * [x] crate-level documentation * [x] test exports * [x] unit and functional tests: to be added in a followup #2296 * [x] use genericity whenever possible * [x] clippy lints # Checklist * [x] implement speculative execution * [x] split execution into worker/exports crates * [x] create massa-ledger crate * [x] integrate execution and ledger into the existing program * [x] repair bootstrap tests * [x] repair consensus tests * [x] improve documentation * [x] try on labnet * [x] reactivate execution tests => will be done in a followup #2296 * [x] add specific tests => will be done in the followup #2296 Co-authored-by: Damir Vodenicarevic <[email protected]> Co-authored-by: damip <[email protected]>
|
Thank you @adrien-zinger and @gterzian for the review |
This was referenced Mar 1, 2022
|
Build failed: |
AureliaDolo
previously approved these changes
Mar 1, 2022
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Mar 1, 2022
2249: Speculative execution support r=damip a=damip # Intro This is a rewrite of the execution system following the spec we already agreed upon, as well as good practices and with the big refactoring constraints in mind. # Goals * [x] enable speculative execution * [x] get ready for ledger unification # Practices * [x] no async because it's not needed * [x] short functions (max 50 lines of code) * [x] no panics, unless described * crates split between worker and exports * [x] execution * [x] ledger: it will be refactored for on-disk storage, we will split it then => #2342 * thorough documentation * [x] function docs * [x] algorithm description * [x] file-level documentation * [x] crate-level documentation * [x] test exports * [x] unit and functional tests: to be added in a followup #2296 * [x] use genericity whenever possible * [x] clippy lints # Checklist * [x] implement speculative execution * [x] split execution into worker/exports crates * [x] create massa-ledger crate * [x] integrate execution and ledger into the existing program * [x] repair bootstrap tests * [x] repair consensus tests * [x] improve documentation * [x] try on labnet * [x] reactivate execution tests => will be done in a followup #2296 * [x] add specific tests => will be done in the followup #2296 Co-authored-by: Damir Vodenicarevic <[email protected]> Co-authored-by: damip <[email protected]>
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Mar 1, 2022
2249: Speculative execution support r=damip a=damip # Intro This is a rewrite of the execution system following the spec we already agreed upon, as well as good practices and with the big refactoring constraints in mind. # Goals * [x] enable speculative execution * [x] get ready for ledger unification # Practices * [x] no async because it's not needed * [x] short functions (max 50 lines of code) * [x] no panics, unless described * crates split between worker and exports * [x] execution * [x] ledger: it will be refactored for on-disk storage, we will split it then => #2342 * thorough documentation * [x] function docs * [x] algorithm description * [x] file-level documentation * [x] crate-level documentation * [x] test exports * [x] unit and functional tests: to be added in a followup #2296 * [x] use genericity whenever possible * [x] clippy lints # Checklist * [x] implement speculative execution * [x] split execution into worker/exports crates * [x] create massa-ledger crate * [x] integrate execution and ledger into the existing program * [x] repair bootstrap tests * [x] repair consensus tests * [x] improve documentation * [x] try on labnet * [x] reactivate execution tests => will be done in a followup #2296 * [x] add specific tests => will be done in the followup #2296 Co-authored-by: Damir Vodenicarevic <[email protected]> Co-authored-by: damip <[email protected]>
|
Build failed: |
damip
dismissed stale reviews from AureliaDolo, adrien-zinger, and gterzian
via
5f4b91b
qdrn
approved these changes
Mar 1, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intro
This is a rewrite of the execution system following the spec we already agreed upon, as well as good practices and with the big refactoring constraints in mind.
Goals
Practices
Checklist