Skip to content
This repository has been archived by the owner on Jun 26, 2018. It is now read-only.

DP-5472 Release 6 Code clean up #601

Open
wants to merge 24 commits into
base: Release-6.0.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
81b5392
DP-5476 - Input Check and Radio - checked is now a boolean
Sep 18, 2017
44abd65
DP-5472 - Comp Heading - 'centered' is now a boolean
Sep 18, 2017
e2d64ca
DP-5472 - Video - removed --new class to toggle old styles
Sep 18, 2017
22d3578
DP-5476 - Link - updated chevron and label variables.
Sep 18, 2017
c4a2102
DP-5472 - Key Actions - removed sidebarHeading variable
Sep 18, 2017
4b4cb3c
DP-5472 - Link List - removing backward compatible flag
Sep 18, 2017
9a0da91
DP-5472 - Header Alert - 'guid' is now 'id'
Sep 18, 2017
8678d74
DP-5472 - Location Banner - bgTitle is now bgInfo
Sep 18, 2017
db4cb57
DP-5472 - Illustrated header - bgTitle is now bgInfo
Sep 18, 2017
f99a612
DP-5472 - bgInfo - updated pages
Sep 18, 2017
c06d64f
DP-5472 - Button - removing old css selectors
Sep 18, 2017
d952170
DP-5472 - Release Notes - recording more changes
Sep 19, 2017
9b7e303
DP-5472 - Comp Heading - 'sub' is now a boolean
Sep 19, 2017
da622b0
DP-5472 - Cat Icon - 'small' is now a boolean
Sep 19, 2017
8c42332
DP-5472 - Table - Cell Heading is now a boolean
Sep 19, 2017
1074443
DP-5472 - Helpful Links - 'columns' is now a boolean
Sep 19, 2017
1f15de7
DP-5476 - Breadcrumbs - 'light' is now a boolean
Sep 19, 2017
1f3d8ad
DP-5476 - Removing string versions of booleans from all patterns
Sep 19, 2017
a596ea1
DP-5476 - Figure - Removing CSS for old align values
Sep 19, 2017
5c40c25
DP-5472 - Top Actions - fixing bad JSON
Sep 19, 2017
3bc20e7
DP-5472 - Removing 'property' variable
Sep 19, 2017
41595dc
DP_5472 - Action Step - removing unneeded CSS
Sep 19, 2017
d250dc2
DP-5472 - Arrow Nav - removing unused CSS
Sep 19, 2017
660ffb2
DP-5472 - Release Notes for v6
Sep 20, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
291 changes: 291 additions & 0 deletions release-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,297 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)

### Migrate Path

## 6.0.0

### Added
- Atoms
- Button Sort
- Button (replaces Button Link)
- Helper Text
- Input Date
- Input Group
- Textarea (replaces Input Textarea)
- Page Title
- Iframe

- Molecules
- Banner Credit
- Date Range
- Error List
- Event Filters
- Event Teaser
- Float Action
- Footnote
- Dvided Inputs
- Labelled List
- Org Selector
- Page Intro
- Press Teaser
- Sort Results
- Tooltip

- Organisms
- Event List
- Footnote List
- Form Requirements
- Page Overview
- Press Filters
- Press Listing
- Content Eyebrow

- Templates
- Events
- Form Page
- Location
- Policy Advisory
- Left Rail

- Pages
- Board Decision
- Event Listing
- Event
- Executive Order
- Form Page Example
- Policy Advisory
- Press Listing
- Press Release
- Topic Your Government
- Video Transcript

### Changed
- Upgraded Pattern Lab to the Drupal Twig version

- Atoms
- Arrow Button
- Input Checkbox
- Input Radio
- Input Text
- Select box (new `required` variable)
- Colored Heading
- Content Heading
- Comp Heading
- Category Icon
- Check List
- Ordered List
- Unordered List
- Figure
- Site Logo
- Video
- Table
- Link
- Publish State
- Decorative Link

- Molecules
- Action Step
- Arrow Nav
- Back Button
- Button Alert
- Callout Link
- Callout Stat
- Contact Group
- Contact Us
- Download Link
- Emergency Header
- Google Map
- Header Search (bug fix)
- Header Tags
- Icon Links
- Image Promo
- Listing Table
- Location Filters
- Location Icons
- Main Nav
- Pagination
- Results Heading
- Search Banner Form
- Section Links
- Social Links

- Organisms
- Action Finder
- Callout Time
- Contact List
- Feedback Form
- Form Downloads
- Helpful Links
- Image Promos
- Key Actions / Callout Grid
- Link List
- Location Banner
- Location Listing
- Mapped Locations
- Personal Message
- Rich Text
- Search Banner
- Sections Three Up
- Search Banner
- Stacked Row Section
- Suggested Pages
- Collage Header
- Emergency Alerts
- Footer
- Header Alert
- Header
- Illustrated Header
- Jump Links
- Page Banner
- Page Header
- Transition Page

- Templates
- Details
- Press
- Services
- Narrrow Template
- Full Width
- Stacked Row Template
- Right Rail

- Pages
- Error 403
- Error 404
- Homepage
- Detail for Service Howto Location
- Guide Section all Fields
- Guide
- Location General Content
- Location Listing
- Location Park Content
- Regulation
- Section Landing
- Topic

- Patterns that were move to an Archived folder
- Blog Feed
- Action Cards
- Action Gallery
- Banner Carousel
- Change Log
- Feedback Form
- Test Feed
- Top Actions
- Collage Header
- Breadcrumbs
- Callout Links

### Removed
- Atoms
- Button Link
- Input Textarea
- Molecules
- Action Event
- Action Image
- Header Contact
- State Util
- Wait Time
- Field Submit
- Related Action
- Organisms
- Action Details
- Quick Actions
- Sidebar Contact
- Sidebar Promo
- Sidebar Widgets
- Rich Text Description
- Teaser Text
- Split50
- Templates
- Announcement (replace by Press)


### Migrate Path (breaking changes)
#### Atoms
- Arrow Button
- Attribure `aria-label` is now `title`
- Button (Button Link)
- css classes have been updated to use modifier classes
- Input Checkbox
- Variable `checked` is now a boolean value
- Includes an optional icon
- Input Radio
- Variable `checked` is now a boolean value
- Comp Heading
- Variable `centered` is now a boolean value
- Variable `sub` is now a boolean value
- Category Icon
- Variable `small` is now boolean
- Figure
- align variable should be `left` and `right`
- Video
- Updated Twig markup to work with new CSS
- Table
- Variable `Table.rows.cells.heading` is now boolean
- Link
- Variable `link.chevron` is now a boolean value
- Variable `label` is now `info`

#### Molecules
- Action Step
- Updated Twig Markup to inlcude the `formDownloads` pattern
_ Arrow Nav
- Updated Twig Markup to include the `link` pattern
- Back Button
- Variable 'link' was replaced by `button`
- Callout Link
- Updated Twig Markup to work with new CSS
- Google Map
- Updated Twig Markup to work with new JS
- Variable `directions` was added
- Image Promo
- Updated Twig Markup and Data Layer
- Location Filters
- Updated Twig Markup and Data Layer to work with new JS
- Main Nav
- Updated Twig Markup to work with new JS
- Pagination
- Updated Twig Markup to work with new JS
- Results Heading
- Updated Twig Markup and Data Layer to work with new JS
- Search Banner Form
- Updated Twig Markup and Data Layer
- Sticky Nav
- Updated Twig Markup


#### Organisms
- Callout Alert
- Updated Twig Markup and Data Layer
- Feedback Form
- Updated Twig Markup and Data Layer
- Helpful Links
- Variable `columns` is now a boolean value
- Key Actions / Callout Grid
- Updated Twig Markup
- Variable `sidebarHeading` is now `compHeading` with `compHeading.sidebar` set to true
- Link List
- Updated Twig Markup and Data Layer
- Location Banner
- Updated Twig Markup and Data Layer
- Location Listing
- Updated Twig Markup and Data Layer to work with new JS
- Personal Message
- Updated Twig Markup and Data Layer
- Variable `imagePromo` changed to an array called `imagePromos`
- Search Banner
- Updated Twig Markup and Data Layer
- Header Alert
- Variable `guid` is now `id`
- Illustrated Header
- Variable `bgTitle` is now `bgInfo`
- Transition Page
- Variable `submit` replace with `submitButton`
- Updated Twig Markup

#### Templates
- Press
- Twig Markup updated to work with new CSS class names
- Services
- Updated Twig Markup and Data Layer
- Stacked Row Template
- Updated Twig Markup and Data Layer


## 5.7.2

### Added
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
{# backward compatible for v5.1 #}
{% if inputCheckbox.checked == 'true' or inputCheckbox.checked == 'false' %}
{% set inputCheckbox = inputCheckbox|merge({'checked': inputCheckbox.checked == 'true' ? true : false }) %}
{% endif %}

<span class="ma__input-checkbox">
<input type="checkbox" value="{{ inputCheckbox.value }}" id="{{ inputCheckbox.id }}" {{ inputCheckbox.checked ? 'checked' : '' }}>
<label for="{{ inputCheckbox.id }}"><span>{{ inputCheckbox.label}}</span></label>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
{# backward compatible for v5.1 #}
{% if inputRadio.checked == 'true' or inputRadio.checked == 'false' %}
{% set inputRadio = inputRadio|merge({'checked': inputRadio.checked == 'true' ? true : false }) %}
{% endif %}

<span class="ma__input-radio">
<input name="{{ inputRadio.name }}" type="radio" value="{{ inputRadio.value }}" id="{{ inputRadio.id }}" {{ inputRadio.checked ? 'checked' : '' }}>
<label for="{{ inputRadio.id }}"><span>{{ inputRadio.label }}</span></label>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
This is a variant of the [Comp Heading](./?p=atoms-comp-heading) showing an example as a sub heading (H3).

### How to generate
* Set the 'sub' variable equal to the boolean value true
* Set the 'sub' variable equal to the true
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"sub": "",
"color": "",
"id": "GUID9827924",
"centered": ""
"centered": false
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ compHeading: {
title:
type: string / required
sub:
type: string ("true" || "" ) / optional
type: boolean
color:
type: string ("yellow") / optional
id:
Expand Down
13 changes: 2 additions & 11 deletions styleguide/source/_patterns/01-atoms/04-headings/comp-heading.twig
Original file line number Diff line number Diff line change
@@ -1,17 +1,8 @@
{% set colored = compHeading.color ? "ma__comp-heading--" ~ compHeading.color : "" %}

{# string value is backward compatible for v5.0.0 #}
{% if compHeading.centered == 'true' or compHeading.centered == 1 %}
{% set compHeading = compHeading|merge({'centered': true}) %}
{% else %}
{% set compHeading = compHeading|merge({'centered': false}) %}
{% endif %}

{% if compHeading.centered %}
{% set centered = "ma__comp-heading--centered" %}
{% endif %}
{% set centered = compHeading.centered ? "ma__comp-heading--centered" : "" %}

{% set sidebar = compHeading.sidebar ? 'ma__comp-heading--sidebar' : '' %}
{% set sidebar = compHeading.sidebar ? "ma__comp-heading--sidebar" : "" %}

{% if compHeading.sub %}
<h3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"sub": true,
"color": "",
"id": "",
"centered": ""
"centered": false
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
This is a variant of the [Cat Icon](./?p=atoms-cat-icon) pattern showing it is in a smaller size.

### How to generate
* set the "small" variable to "true"
* set the "small" variable to true
4 changes: 2 additions & 2 deletions styleguide/source/_patterns/01-atoms/05-icons/cat-icon.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"catIcon": {
"icon":"@atoms/05-icons/svg-lg-picnic-table.twig",
"small":""
"icon": "@atoms/05-icons/svg-lg-picnic-table.twig",
"small": false
}
}
2 changes: 1 addition & 1 deletion styleguide/source/_patterns/01-atoms/05-icons/cat-icon.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ catIcon: {
icon:
type: string (path to icon) / required
small:
type: string ("true" || "") / optional
type: boolean
}
~~~

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<figure class="ma__category-icon {{catIcon.small == "true" ? 'ma__category-icon--small' : ''}}" aria-hidden>
<figure class="ma__category-icon {{ catIcon.small ? 'ma__category-icon--small' : '' }}" aria-hidden>
{% include catIcon.icon %}
</figure>

Loading