Skip to content
This repository has been archived by the owner on Jun 26, 2018. It is now read-only.

DP-8825 Add expandable teaser listing for org boards #816

Merged
merged 12 commits into from
May 14, 2018
Merged

DP-8825 Add expandable teaser listing for org boards #816

merged 12 commits into from
May 14, 2018

Conversation

isaacchansky
Copy link
Contributor

Description

Adds a variation of the teaser listing organism to allow for an accordion layout.

Related Issue / Ticket

Steps to Test

  1. Run maflower locally
  2. Ensure than the existing listing table organism works and looks as it used to
  3. Look at the organization boards page, and see that it matches these invision links:

Screenshots

Additional Notes:

Anything else to add?

Impacted Areas in Application

  • Added `@organisms/by-author/teaser-listing~as-expandable

@todo

  • Maybe add blocks around each item subsection?

Today I learned...

@isaacchansky
Copy link
Contributor Author

@tnathanjames is this an instance where we would want two blocks around each sub-section of items in the twig file?

@tnathanjames
Copy link
Contributor

It looks like these blocks are the same, it is just the number of items that changes? If that is the case, it might make sense to provide something like we did in this PR: https://github.com/massgov/mayflower/pull/801/files, printing the block that was previously defined.

@isaacchansky
add variable for adjusting shown items in teaser listing
2338aa6
@isaacchansky
Merge branch 'dev' into DP-8825-board-org-accordion-members
687f82f 
* dev:
  DP-8363: Reduce the front end performance impact of the main logo and state seal (#807)
  DP-7761: Add sanitization of text in map pin title (#797)
  DP-6715: image promos (#810)
@isaacchansky
add blocks
33385a9
@isaacchansky
set max width to fix IE 11 jank
c6945db
@isaacchansky
accept changed ref imgs
c568674
@isaacchansky
adjust labels for board accordion and up shown #
c3a12e0
@isaacchansky
update ref imgs
9a7d04e
@isaacchansky
reduce # of board members in primary section, ditch the non-necessary…
bf4842b 
… flex-basis declaration that confuses IE11
@isaacchansky
Merge branch 'dev' into DP-8825-board-org-accordion-members
acdb4c2 
* dev:
  Updated the package.json version to  5.22.0
  Removed changelogs txt files for 5.22.0
  Added release notes for 5.22.0
  DP-8877: Short description on org page separate from contact row (#819)
  DP-8880: Allow sidebar of stacked row to be overridden (#820)
clair0917
clair0917 approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@clair0917 clair0917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@tnathanjames tnathanjames merged commit ca05e6b into dev May 14, 2018
isaacchansky added a commit that referenced this pull request May 14, 2018
@isaacchansky
Merge branch 'dev' into DP-8942-add-rows-to-elected-org
7b1523c 
* dev:
  DP-8940:  Increase font size of short description on org pages (#829)
  DP-8890: Always print stickTOC expander to let JS handle visibility (#830)
  DP-8825 Add expandable teaser listing for org boards (#816)
  DP-8924: reorder org page to have featured topics above news (#826)
  removed the deploy to github pages script
  Make a change to the developer deployment text.
  removed the line for it was said in the following step
  removed the developer deploy doc
  update the developer deployment section
  update developer deployment in the readme
  Removed the rollback steps for this not accurate anymore
  fixing the link creating the release step
isaacchansky added a commit that referenced this pull request May 14, 2018
@isaacchansky
Merge branch 'dev' into DP-8948--contact-information-on-org-page-spacing
8bfef87 
* dev:
  DP-8942: Add sections to elected official page (#828)
  DP-8940:  Increase font size of short description on org pages (#829)
  DP-8890: Always print stickTOC expander to let JS handle visibility (#830)
  DP-8825 Add expandable teaser listing for org boards (#816)
  DP-8924: reorder org page to have featured topics above news (#826)
  removed the deploy to github pages script
  Make a change to the developer deployment text.
  removed the line for it was said in the following step
  removed the developer deploy doc
  update the developer deployment section
  update developer deployment in the readme
  Removed the rollback steps for this not accurate anymore
  fixing the link creating the release step
isaacchansky added a commit that referenced this pull request May 15, 2018
@isaacchansky
Merge branch 'dev' into DP-8948--contact-information-on-org-page-spacing
728aff1 
* dev:
  DP-8942: Add sections to elected official page (#828)
  DP-8940:  Increase font size of short description on org pages (#829)
  DP-8890: Always print stickTOC expander to let JS handle visibility (#830)
  DP-8825 Add expandable teaser listing for org boards (#816)
  DP-8924: reorder org page to have featured topics above news (#826)
  removed the deploy to github pages script
  Make a change to the developer deployment text.
  removed the line for it was said in the following step
  removed the developer deploy doc
  update the developer deployment section
  update developer deployment in the readme
  Removed the rollback steps for this not accurate anymore
  fixing the link creating the release step
isaacchansky added a commit that referenced this pull request May 15, 2018
@isaacchansky
Merge branch 'dev' into DP-8948--contact-information-on-org-page-spacing
a82dde2 
* dev:
  DP-8942: Add sections to elected official page (#828)
  DP-8940:  Increase font size of short description on org pages (#829)
  DP-8890: Always print stickTOC expander to let JS handle visibility (#830)
  DP-8825 Add expandable teaser listing for org boards (#816)
  DP-8924: reorder org page to have featured topics above news (#826)
  removed the deploy to github pages script
  Make a change to the developer deployment text.
  removed the line for it was said in the following step
  removed the developer deploy doc
  update the developer deployment section
  update developer deployment in the readme
  Removed the rollback steps for this not accurate anymore
  fixing the link creating the release step
isaacchansky added a commit that referenced this pull request May 15, 2018
@isaacchansky
Merge branch 'dev' into DP-8956-contact-us-2-groups
2aaf006 
* dev:
  DP-8948  contact information on org page spacing (#831)
  DP-8942: Add sections to elected official page (#828)
  DP-8940:  Increase font size of short description on org pages (#829)
  DP-8890: Always print stickTOC expander to let JS handle visibility (#830)
  DP-8825 Add expandable teaser listing for org boards (#816)
  DP-8924: reorder org page to have featured topics above news (#826)
  removed the deploy to github pages script
  Make a change to the developer deployment text.
  removed the line for it was said in the following step
  removed the developer deploy doc
  update the developer deployment section
  update developer deployment in the readme
  Removed the rollback steps for this not accurate anymore
  fixing the link creating the release step
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clair0917 clair0917 clair0917 approved these changes

@tnathanjames tnathanjames Awaiting requested review from tnathanjames

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacchansky @tnathanjames @clair0917