Skip to content
This repository has been archived by the owner on Jun 26, 2018. It is now read-only.

Dp 8266 print styles for guides -- Do Not Merge #818

Closed
wants to merge 24 commits into from

Conversation

isaacchansky
Copy link
Contributor

@isaacchansky isaacchansky commented May 7, 2018

A New PR has been included with the PR found here: massgov/mayflower#862

This PR should not be merged

Description

This PR cleans up and organizes a bunch of print CSS for Mayflower. This is a work in progress but this is a first pass at an overhaul to cover the majority of the more egregious components.

Related Issue / Ticket

Steps to Test

  • Review each page in mayflower and ensure that things are readable. This is a first pass, so it's likely that some components will need some more work down the road. Please feel free to add Jira tickets for components that require further work to be perfect. Small tweaks for overlapping or otherwise unreadable text we should fix in this PR.
  • I'd recommend using Chrome Dev Tools to test print styles.
    • To enable those, open chrome dev tools, open the console drawer (esc key) using the menu within that drawer, open the rendering tab, then select print rendering from the bottom dropdown in that list. This is confusing to find... so see attached gif for reference!

chrome-print-dev-tools

Screenshots

Use something like licecap to capture gifs to demonstrate behaviors.

Additional Notes:

Anything else to add?

Impacted Areas in Application

  • _print.scss

@todo

  • Action finders specifically are kind of gross and should have a unique print treatment I think - though I believe they are passable for now.

  • We may want to consider saving ink and avoiding having colored backgrounds wherever possible.

@clair0917 clair0917 changed the title Dp 8266 print styles for guides Dp 8266 print styles for guides -- Do Not Merge Jun 13, 2018
@clair0917
Copy link
Contributor

Closing this PR in favor of the more recent updates found here: massgov/mayflower#862

@clair0917 clair0917 closed this Jun 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants