Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-12682/DP-12682 How to page template mapping #485

Merged
merged 14 commits into from
Mar 19, 2019

Conversation

mrossi113
Copy link
Contributor

@mrossi113 mrossi113 commented Feb 22, 2019

Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions

Description

Some changes were needed on the Mayflower side to allow the template mapping of the How-to page to work correctly in Drupal. Removed the How-to social media links from the How-to page and added a block to the tabular-data.twig.

Related Issue / Ticket

Steps to Test

  1. Compare the How to page http://localhost:3000/?p=pages-howto vs https://mayflower.digital.mass.gov/?p=pages-howto
  2. The following text was changed: Next Steps to Next steps and How To Apply to How to apply to match the www.mass.gov styleguide.
  3. Social media links in the header should be the only item that has been removed from the Howto page. Everything else should be the same.
  4. Compare the tabular-data.twig http://localhost:3000/?p=organisms-tabular-data vs https://mayflower.digital.mass.gov/?p=organisms-tabular-data. This should not have any changes to this organism with the block being added.

Screenshots

Use something like licecap to capture gifs to demonstrate behaviors.
Howto page removed these social media links:
howto page change

Additional Notes:

Anything else to add?

Impacted Areas in Application

@todo

Today I learned...

@samseide samseide merged commit 2740162 into develop Mar 19, 2019
@samseide samseide deleted the DP-12682-how-to-page-template-mapping branch March 19, 2019 19:34
@clairesunstudio clairesunstudio mentioned this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants