Patternlab/DP-12843 changes to location page to show links to all locations #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3--changes-to-location-page-to-show-links-to-all-locations
…3--changes-to-location-page-to-show-links-to-all-locations
…3--changes-to-location-page-to-show-links-to-all-locations
sumeetpareek
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Awesome, LGTM. Have also created corresponding drupal jira for it here - https://jira.mass.gov/browse/DP-13072
Merged
avrilpearl
deleted the
patternlab/DP-12843--changes-to-location-page-to-show-links-to-all-locations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new related/nearby locations pattern
Related Issue / Ticket
Steps to Test
Test in page: https://mayflower.digital.mass.gov/b/patternlab/DP-12843--changes-to-location-page-to-show-links-to-all-locations/patterns/05-pages-location-park-content/05-pages-location-park-content.html
Test pattern: https://mayflower.digital.mass.gov/b/patternlab/DP-12843--changes-to-location-page-to-show-links-to-all-locations/patterns/03-organisms-by-author-related-locations/03-organisms-by-author-related-locations.html
Test 2 locations variation: https://mayflower.digital.mass.gov/b/patternlab/DP-12843--changes-to-location-page-to-show-links-to-all-locations/patterns/03-organisms-by-author-related-locations-no-related/03-organisms-by-author-related-locations-no-related.html
Test no locations variation: https://mayflower.digital.mass.gov/b/patternlab/DP-12843--changes-to-location-page-to-show-links-to-all-locations/patterns/03-organisms-by-author-related-locations-no-related/03-organisms-by-author-related-locations-no-related.html
Screenshots