react/DP-13169: Add default header search behavior. #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| render() { | ||
| const headerSearch = this.props; | ||
| const orgDropdown = headerSearch.orgDropdown; | ||
| const shouldShowTypeAhead = (orgDropdown && orgDropdown.dropdownButton && orgDropdown.inputText); | ||
| const { onClick, ...buttonSearchRest } = headerSearch.buttonSearch; |
There was a problem hiding this comment.
looks good!, should we remove onSubmit since we decide not to use it
| * @param {object} event - The click event. | ||
| * @param {string} query - The current query string input. | ||
| */ | ||
| this.props.buttonSearch.onClick({ event: e, query: this.state.value }); |
There was a problem hiding this comment.
You should not be passing the event as it will have expired for whatever set buttonSearch.onClick.
| * @param {string} query - The current query string input. | ||
| */ | ||
| this.props.buttonSearch.onClick({ event: e, query: this.state.value }); | ||
| } else if (this.state.value && this.state.value.length > 0) { |
There was a problem hiding this comment.
Suggested change
| } else if (this.state.value && this.state.value.length > 0) { | |
| } else if (this.state.value && !is.empty(this.state.value)) { |
| @@ -55,7 +73,10 @@ class HeaderSearch extends React.Component { | |||
| <div className="ma__header-search__post-filter"> | |||
| {this.props.postInputFilter} | |||
| </div> | |||
| <ButtonWithIcon {...headerSearch.buttonSearch} /> | |||
| <ButtonWithIcon | |||
| onClick={(e) => this.handleClick(e)} | |||
There was a problem hiding this comment.
Suggested change
| onClick={(e) => this.handleClick(e)} | |
| onClick={this.handleClick} |
Co-Authored-By: avrilpearl <[email protected]>
Co-Authored-By: avrilpearl <[email protected]>
Co-Authored-By: avrilpearl <[email protected]>
avrilpearl
commented
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds default behaviour, if an onClick buttonSearch prop is not passed to the headerSearch molecule - redirects on click to search.mass.gov.
For storybook - test this in the iframe story by commenting --> e.g. http://localhost:6006/iframe.html?id=molecules-headersearch--headersearch
Note: will need to comment out the story
action