Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-13951 add more links to suggested pages template #562

Merged
merged 12 commits into from
Jun 24, 2019

Conversation

a-username
Copy link
Contributor

@a-username a-username commented May 21, 2019

Description

Add option to use link list instead of more link in suggested pages template.

Related Issue / Ticket

Steps to Test

  • Go to the suggested pages organism at Organisms > By-author > Suggested pages
  • Verify there is now a left-aligned list of links below the image set
  • Verify the center-aligned "More" link still displays below the list of links.

https://mayflower.digital.mass.gov/b/DP-13951-suggested-pages/index.html

Screenshots

2019-05-30_1374x594

Additional Notes:

This change is brought about by DP-13072 where the more link is replaced by the link list. Instead of removing the more link entirely I'm opting to have the list be optional this way we're not introducing any potential breaking change in the template. All functionality should remain the same for existing use of the "more" link + the new link list should not render unless intended.

Impacted Areas in Application

@todo

Today I learned...

Copy link
Contributor

@mrossi113 mrossi113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@mrossi113 mrossi113 merged commit fe58f50 into develop Jun 24, 2019
@mrossi113 mrossi113 deleted the DP-13951-suggested-pages branch June 24, 2019 20:40
@clairesunstudio clairesunstudio mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants