Refactored rules

[thomasduenser]

• Updated eslint
• Removed/replaced deprecated rules
• Changed env values
• Replaced " with '

[thomasduenser]

@cbl6499 @martinlagler @Quehnie @mscharl @alexander-schranz Please review.

Some rules are deprecated which could be replaced with the node plugin (https://www.npmjs.com/package/eslint-plugin-node). Should this be part of the standard config here?

Additionally a rule to check the JSDoc has been deprecated, which could be replaced with the eslint plugin (https://www.npmjs.com/package/eslint-plugin-jsdoc). Should this be part of the standard config here?

ℹ️ All available rules are available here: https://eslint.org/docs/latest/rules/

[cbl6499]

Install https://www.npmjs.com/package/eslint-plugin-import and use the plugin
plugins: ['import'],

Additional rules that we use in our projects.

'arrow-parens': ['error', 'always'],
'no-console': 'error',
'import/order': [
    'error',
    {
        alphabetize: {
            order: 'asc',
            caseInsensitive: true,
        },
    },
],
'import/no-dynamic-require': 'error',
'import/no-webpack-loader-syntax': 'error',
'import/export': 'error',
'import/no-extraneous-dependencies': 'error',
'import/no-nodejs-modules': 'error',
'import/first': 'error',
'import/no-duplicates': 'error',
'import/no-absolute-path': 'error',
'import/no-unused-modules': 'error',
'import/newline-after-import': ['error', { count: 1 }],

[thomasduenser]

@cbl6499 Done, thank you!

[sabinebaer]

@thomasduenser All rules are ok for me but max-lines-per-function and complexity could be added (with same values as in PHP).

[sabinebaer]

@thomasduenser All rules are ok for me but max-lines-per-function and complexity could be added (with same values as in PHP).

As discussed we will not include those two rules for the moment

[alexander-schranz]

this should be a normal dependency like stylelint prepend: https://github.com/massiveart/stylelint-config-ma/blob/c696964e740ce65776a6629708a84bc0fad0d508/package.json#L25

[thomasduenser]

@alexander-schranz Thanks, done!

[alexander-schranz]

We should keep this test else eslint fixer does convert $.Deferred to $.deferred which actually targets a not existing jquery method:

#2

[thomasduenser]

@alexander-schranz Done!