Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consecutive request with curl fails #5

Closed
tigerduck42 opened this issue Oct 29, 2018 · 2 comments
Closed

Consecutive request with curl fails #5

tigerduck42 opened this issue Oct 29, 2018 · 2 comments

Comments

@tigerduck42
Copy link

Hi,

I realised, that any consecutive request will fail, if curl is used. The reason I found was, that the headers returned by Apache are postfixed with "\r\n" therfore my suggestion is to trim the second part as well in parseCookies()

https://github.com/matasarei/JsonRPC/blob/master/src/JsonRPC/HttpClient.php#L374

What are your thoughts?

@matasarei
Copy link
Owner

Hello @tigerduck42!

Yes, seems you right. Here you can see changes I've made:
https://github.com/matasarei/JsonRPC/pull/6/files

Please try this fix with your code:

composer require fguillot/json-rpc:dev-fix-consecutive-request-with-url-fails

Waiting for your feedback.

@tigerduck42
Copy link
Author

Hello Yevhen,

looks good, my unit tests are successful.
Ready to ship and pack ;-)

matasarei pushed a commit that referenced this issue Jun 8, 2024
…actions

replace travis with GitHub actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants