This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Update snapshot to 7123292 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
approved these changes
Feb 8, 2021
lib/src/main/java/com/google/android/material/composethemeadapter/TypedArrayUtils.kt
Outdated
Show resolved
Hide resolved
chrisbanes
reviewed
Feb 8, 2021
| topRight = cornerSizeTR ?: defaultCornerSize ?: fallbackShape.topRight, | ||
| bottomRight = cornerSizeBR ?: defaultCornerSize ?: fallbackShape.bottomRight, | ||
| bottomLeft = cornerSizeBL ?: defaultCornerSize ?: fallbackShape.bottomLeft | ||
| topStart = cornerSizeTS ?: defaultCornerSize ?: fallbackShape.topStart, |
There was a problem hiding this comment.
Just checking, but this isn't what I meant. The attributes are left/right so you need to convert them to start/end based on the layout direction. Currently the values are only correct in LTR, not RTL.
There was a problem hiding this comment.
Aaah my bad. I'll open a new PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.