Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Commit

Permalink
feat(select): Change stylelint directive, update dependencies, add ri…
Browse files Browse the repository at this point in the history
…pple
  • Loading branch information
amsheehan committed Oct 31, 2017
1 parent 28a8c11 commit 689cf23
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
8 changes: 2 additions & 6 deletions packages/mdc-select/mdc-select.scss
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,6 @@ $mdc-select-label-padding: 16px;
content: "";
}

// NOTE: For some reasons, stylelint complains that the two patterns below don't follow BEM.
// However, it seems to emit the wrong selector for that pattern. Thus, we disable it above where
// we would normally disable it (&.mdc-textfield--disabled) as a workaround.

// stylelint-disable plugin/selector-bem-pattern
&:hover {
.mdc-select__bottom-line {
transform: scaleY(2);
Expand Down Expand Up @@ -320,6 +315,7 @@ $mdc-select-label-padding: 16px;
@include mdc-theme-prop(border-color, text-hint-on-dark);
}

// stylelint-disable plugin/selector-bem-pattern
.mdc-list-group {
@include mdc-theme-prop(color, text-hint-on-light);

Expand All @@ -338,8 +334,8 @@ $mdc-select-label-padding: 16px;
.mdc-list-divider {
margin-left: -16px;
}
// stylelint-enable
}
// stylelint-enable plugin/selector-bem-pattern

// stylelint-disable plugin/selector-bem-pattern
.mdc-list-item {
Expand Down
6 changes: 3 additions & 3 deletions packages/mdc-select/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
"dependencies": {
"@material/animation": "^0.4.1",
"@material/base": "^0.2.6",
"@material/ripple": "^0.8.8",
"@material/list": "^0.23.0",
"@material/menu": "^0.23.0",
"@material/ripple": "^0.24.0",
"@material/list": "^0.24.0",
"@material/menu": "^0.24.0",
"@material/rtl": "^0.1.8",
"@material/theme": "^0.4.0",
"@material/typography": "^0.3.0"
Expand Down

0 comments on commit 689cf23

Please sign in to comment.