Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect class name used for mdc-toolbar-fixed-adjust #320

Closed
ghost opened this issue Feb 21, 2017 · 3 comments
Closed

Incorrect class name used for mdc-toolbar-fixed-adjust #320

ghost opened this issue Feb 21, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented Feb 21, 2017

What MDC-Web Version are you using?

v0.5.0

What browser(s) is this bug affecting?

Every.

What OS are you using?

4.9.9-1-ARCH

What are the steps to reproduce the bug?

Follow the fixed toolbar documentation.

What is the expected behavior?

Add top margin to the siblings of the fixed toolbar.

What is the actual behavior?

No added margin caused by two typos in the documentation.

Any other information you believe would be useful?

I can quickly provide a pull request to fix this.

@traviskaufman
Copy link
Contributor

This actually seems like it's a bug in our toolbar code. That class should be mdc-toolbar-fixed-adjust, since the __ modifier is reserved for children of the MDC-Toolbar component (e.g. mdc-toolbar__section). We should be able to make a hotfix patch release for this today.

@traviskaufman traviskaufman changed the title Typos in the documentation of mdc toolbar Incorrect class name used for mdc-toolbar-fixed-adjust Feb 21, 2017
@ghost
Copy link
Author

ghost commented Feb 21, 2017

Provided a PR #321 .

@Hardtack
Copy link

It seems that you did not update CSS file before publishing [email protected]

SCSS file's class name was updated, but CSS file was not. 😢

$ cat node_modules/@material/toolbar/package.json | ack version
  "version": "0.1.1"

$ cat node_modules/@material/toolbar/dist/mdc.toolbar.css | ack mdc-toolbar
.mdc-toolbar {
    .mdc-toolbar {
  .mdc-toolbar__section {
    .mdc-toolbar__section--align-start {
    .mdc-toolbar__section--align-end {
    .mdc-toolbar__section .mdc-toolbar__title {
.mdc-toolbar--fixed {
.mdc-toolbar__fixed-adjust {
    .mdc-toolbar__fixed-adjust {

$ cat node_modules/@material/toolbar/mdc-toolbar.scss | ack mdc-toolbar
$mdc-toolbar-height: 64px;
$mdc-toolbar-mobile-height: 56px;
$mdc-toolbar-padding: 24px 16px;
$mdc-toolbar-mobile-padding: 16px;
$mdc-toolbar-mobile-breakpoint: 599px;
.mdc-toolbar {
  height: $mdc-toolbar-height;
  padding: $mdc-toolbar-padding;
  @media (max-width: $mdc-toolbar-mobile-breakpoint) {
    height: $mdc-toolbar-mobile-height;
    padding: $mdc-toolbar-mobile-padding;
    .mdc-toolbar__title {
.mdc-toolbar--fixed {
.mdc-toolbar-fixed-adjust {
  margin-top: $mdc-toolbar-height;
    margin-top: $mdc-toolbar-mobile-height;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants