Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Select option list follows page scroll #1500

Merged
merged 13 commits into from
Nov 20, 2017
Merged

Select option list follows page scroll #1500

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6dfc530
Select option list follows page scroll
roncapat Oct 27, 2017
740fcaf
CSS lint fix
roncapat Oct 27, 2017
c25633f
Lint fix (not my fault)
roncapat Oct 27, 2017
d4af29d
Change property in the right place
roncapat Oct 28, 2017
ac103eb
No scroll if dropdown is open
roncapat Oct 28, 2017
7eb43d5
Linting fixes
roncapat Oct 28, 2017
84eb9b8
Tests fix
roncapat Oct 28, 2017
50bea8f
Restore original position attribute
roncapat Oct 28, 2017
91a660a
Merge branch 'master' into scroll
lynnmercier Nov 16, 2017
f9a5365
Requested fixes - 1
roncapat Nov 16, 2017
2586a4f
Merge branch 'master' into scroll
roncapat Nov 18, 2017
595b0dd
Requested fixes - 2
roncapat Nov 18, 2017
1047b90
Merge branch 'master' into scroll
roncapat Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/mdc-select/mdc-select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@
// postcss-bem-linter: end

.mdc-select__menu {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make those changes on line 82 instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see d4af29d

position: absolute;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add a new one, just edit the the position: fixed on line 83

z-index: 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The menu already has a z-index of 4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's normal that it goes above the header?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not sure. Setting its z-index to 3 may make it go under some other components.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'll leave value 4 in order to avoid some unnoticed changes of behaviour in other situations for now.


.mdc-list-item {
@include mdc-typography(subheading2);
@include mdc-theme-prop(color, text-secondary-on-light);
Expand Down
2 changes: 1 addition & 1 deletion scripts/rewrite-decl-statements-for-closure-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* * Rewrite import Foo from './foo' to const Foo = goog.require('mdc.foo')
* * Rewrite import {foo, bar} from './util' to const {foo, bar} = goog.require('mdc.util')
*
*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running npm run lint resulted in an error pointing to this line. I noticed that on TravisCI, and so I made this fix to let the validation process continue.

*
* This script rewrites import statements such that:
*
* ```js
Expand Down