-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Select option list follows page scroll #1500
Changes from 10 commits
6dfc530
740fcaf
c25633f
d4af29d
ac103eb
7eb43d5
84eb9b8
50bea8f
91a660a
f9a5365
2586a4f
595b0dd
1047b90
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,6 +112,8 @@ export class MDCSelect extends MDCComponent { | |
deregisterMenuInteractionHandler: (type, handler) => this.menu_.unlisten(type, handler), | ||
notifyChange: () => this.emit(MDCSelectFoundation.strings.CHANGE_EVENT, this), | ||
getWindowInnerHeight: () => window.innerHeight, | ||
addBodyClass: (className) => document.body.classList.add(className), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do you add this class to the document body? Why can't this class be added directly to the this.root_ element? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. He is looking at the same implementation for the drawer and doing the same here 😃 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks for the context @touficbatache |
||
removeBodyClass: (className) => document.body.classList.remove(className), | ||
}); | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -264,3 +264,8 @@ | |
// with CSS. Use the font-size rule instead. | ||
|
||
// postcss-bem-linter: end | ||
|
||
.mdc-select-scroll-lock { | ||
height: 100vh; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do you need to set the hight? Is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's just like that in the drawer implementation There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
overflow: hidden; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -207,7 +207,7 @@ $material-color-yellow-700: #fbc02d; | |
$material-color-yellow-800: #f9a825; | ||
$material-color-yellow-900: #f57f17; | ||
$material-color-yellow-a100: #ffff8d; | ||
$material-color-yellow-a200: #ffff00; | ||
$material-color-yellow-a200: #ff0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this changes seems to have sneaked into this PR...can you make sure packages/mdc-theme/_color-palette.scss is the exact same as our master branch? |
||
$material-color-yellow-a400: #ffea00; | ||
$material-color-yellow-a700: #ffd600; | ||
|
||
|
@@ -269,7 +269,7 @@ $material-color-brown-900: #3e2723; | |
|
||
$material-color-grey-50: #fafafa; | ||
$material-color-grey-100: #f5f5f5; | ||
$material-color-grey-200: #eeeeee; | ||
$material-color-grey-200: #eee; | ||
$material-color-grey-300: #e0e0e0; | ||
$material-color-grey-400: #bdbdbd; | ||
$material-color-grey-500: #9e9e9e; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this changes seems to have sneaked into this PR...can you make sure packages/mdc-checkbox/_mixins.scss is the exact same as our master branch?