This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
chore(text-field): moved textarea sass into private mixins #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moog16
commented
Jan 11, 2018
| @@ -432,91 +424,9 @@ | |||
| } | |||
|
|
|||
| .mdc-text-field--textarea { | |||
| @include mdc-text-field-textarea-corner-radius($mdc-text-field-border-radius); | |||
There was a problem hiding this comment.
This is all a copy paste into mixins_.scss
moog16
commented
Jan 11, 2018
| @@ -399,14 +399,6 @@ | |||
| @include mdc-text-field-invalid_; | |||
| } | |||
|
|
|||
| // stylelint-disable plugin/selector-bem-pattern | |||
|
|
|||
| .mdc-text-field--invalid.mdc-text-field--textarea { | |||
There was a problem hiding this comment.
this was moved into the bottom of the main textarea mixins_.scss selector
moog16
commented
Jan 11, 2018
| } | ||
| } | ||
|
|
||
| .mdc-text-field--textarea.mdc-text-field--focused { |
There was a problem hiding this comment.
this was also moved into the bottom of the main textarea mixins_.scss selector
Codecov Report
@@ Coverage Diff @@
## master #1942 +/- ##
==========================================
- Coverage 99.43% 99.43% -0.01%
==========================================
Files 84 84
Lines 3718 3710 -8
Branches 486 484 -2
==========================================
- Hits 3697 3689 -8
Misses 21 21
Continue to review full report at Codecov.
|
lynnmercier
suggested changes
Jan 12, 2018
packages/mdc-textfield/_mixins.scss
Outdated
| @@ -243,6 +243,108 @@ | |||
| } | |||
| } | |||
|
|
|||
| @mixin mdc-text-field-textarea-invalid_ { | |||
| // stylelint-disable plugin/selector-bem-pattern | |||
There was a problem hiding this comment.
you dont need this stylelint disable/enable comments any more
packages/mdc-textfield/_mixins.scss
Outdated
| background-color: $mdc-textarea-dark-background; | ||
| } | ||
|
|
||
| &--float-above { |
There was a problem hiding this comment.
remove this & syntax and just use .mdc-text-field__label--float-above
added 9 commits
January 16, 2018 10:19
acdvorak
added a commit
that referenced
this pull request
Jan 17, 2018
commit 1e8970f Author: Matty Goo <[email protected]> Date: Wed Jan 17 09:19:54 2018 -0800 chore(text-field): moved textarea sass into private mixins (#1942) commit bffadd3 Author: Andrew C. Dvorak <[email protected]> Date: Wed Jan 17 09:09:56 2018 -0800 style(demos): Clean up theme demo Sass and HTML (#1973) - Remove unused code - IE 11 compatible property values (`unset` -> `auto`) - Fix duplicate IDs - Use `--stroked` buttons instead of `--raised` for checkbox demo - Rename CSS classes to be more BEM-y - Rename and reorganize Sass demo vars - Reword text-field labels and helper text for clarity - Remove `getAll()` - Inline some JS vars commit 3a1786f Author: Dominic Carretto <[email protected]> Date: Wed Jan 17 11:37:03 2018 -0500 fix(slider): Add MDCSliderFoundation export (#1959) commit 815eade Author: Simon Olofsson <[email protected]> Date: Wed Jan 17 17:36:07 2018 +0100 docs(menu): Remove obsolete `mdc-simple-menu--open-from` classes. (#1927) commit 6078784 Author: Chafic Najjar <[email protected]> Date: Wed Jan 17 18:26:00 2018 +0200 docs: Rewrite all instances of "MDC-Web" as "MDC Web" (#1960) Resolves #1924 commit e87c110 Author: pndewit <[email protected]> Date: Wed Jan 17 17:23:03 2018 +0100 docs(drawer): Fix missing link to temporary drawer demo (#1922) commit 003dff4 Author: Chafic Najjar <[email protected]> Date: Wed Jan 17 18:20:35 2018 +0200 docs: Fix broken links to AngularJS's Git commit guidelines (#1888)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial fix of: #1598
refactor sass for textarea invalid and focused states