Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): Export util methods in index.js #423

Merged
merged 5 commits into from
Mar 29, 2017

Conversation

pgbross
Copy link
Contributor

@pgbross pgbross commented Mar 22, 2017

Resolves #422

@codecov-io
Copy link

codecov-io commented Mar 22, 2017

Codecov Report

Merging #423 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          40       40           
  Lines        2036     2036           
  Branches      260      260           
=======================================
  Hits         2019     2019           
  Misses         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888be2c...c0e0a28. Read the comment docs.

@amsheehan
Copy link
Contributor

This looks good to me. Please rebase with a fresh pull on master so we can try and get codecov to pass. Thanks for the PR!

@amsheehan
Copy link
Contributor

amsheehan commented Mar 23, 2017

@pgbross Please add documentation to the README explaining that users can now use mdc-drawer/util. Thanks!

Copy link
Contributor

@traviskaufman traviskaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💎

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@traviskaufman traviskaufman merged commit 1babd7c into material-components:master Mar 29, 2017
@pgbross pgbross deleted the pgbr-vue3 branch March 29, 2017 14:43
pgbross pushed a commit to pgbross/material-components-web that referenced this pull request Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants