-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(drawer): Export util methods in index.js #423
Conversation
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 40 40
Lines 2036 2036
Branches 260 260
=======================================
Hits 2019 2019
Misses 17 17 Continue to review full report at Codecov.
|
This looks good to me. Please rebase with a fresh pull on master so we can try and get codecov to pass. Thanks for the PR! |
@pgbross Please add documentation to the README explaining that users can now use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 💎
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Resolves #422