Skip to content

Commit

Permalink
fix(tabs)!: change compound attribute names to kebab case
Browse files Browse the repository at this point in the history
BREAKING_CHANGE: Attributes `selectonfocus` and `inlineicon` have been changed to `select-on-focus` and `inline-icon` respectively.
PiperOrigin-RevId: 542412826
  • Loading branch information
AndrewJakubowicz authored and copybara-github committed Jun 22, 2023
1 parent a8e489e commit a9d030a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tabs/lib/tab.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class Tab extends LitElement {
/**
* Whether or not the icon renders inline with label or stacked vertically.
*/
@property({type: Boolean}) inlineIcon = false;
@property({type: Boolean, attribute: 'inline-icon'}) inlineIcon = false;

@query('.button') private readonly button!: HTMLElement|null;

Expand Down
3 changes: 2 additions & 1 deletion tabs/lib/tabs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ export class Tabs extends LitElement {
/**
* Whether or not to select an item when focused.
*/
@property({type: Boolean}) selectOnFocus = false;
@property({type: Boolean, attribute: 'select-on-focus'})
selectOnFocus = false;

private previousSelected = -1;
private orientation = 'horizontal';
Expand Down

0 comments on commit a9d030a

Please sign in to comment.