Skip to content

Commit

Permalink
docs(menu): set target to _blank in demos
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 587866823
  • Loading branch information
Elliott Marquez authored and copybara-github committed Dec 4, 2023
1 parent af49b64 commit aafea84
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
4 changes: 0 additions & 4 deletions menu/demo/demo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,6 @@ const collection = new MaterialCollection<KnobTypesToKnobs<StoryKnobs>>(
defaultValue: 'https://google.com',
ui: textInput(),
}),
new Knob('target', {
defaultValue: '',
ui: textInput(),
}),
new Knob('link icon', {
defaultValue: 'open_in_new',
ui: textInput(),
Expand Down
8 changes: 1 addition & 7 deletions menu/demo/stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ export interface StoryKnobs {
keepOpen: boolean;
disabled: boolean;
href: string;
target: string;
'link icon': string;

'sub-menu': void;
Expand Down Expand Up @@ -154,13 +153,8 @@ const linkable: MaterialStoryInit<StoryKnobs> = {
const items = fruitNames.map((name, index) => {
return html` <md-menu-item
id=${index}
target="_blank"
.disabled=${knobs.disabled}
.target=${knobs.target as
| ''
| '_blank'
| '_parent'
| '_self'
| '_top'}
.href=${knobs.href}>
<div slot="headline">${name}</div>
<md-icon slot="end"> ${knobs['link icon']} </md-icon>
Expand Down

0 comments on commit aafea84

Please sign in to comment.