-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ID generation scheme #55
Conversation
4a74d77
to
33bfbfe
Compare
33bfbfe
to
53d9ac7
Compare
8157034
to
db57310
Compare
a5fed0f
to
f3a5c3b
Compare
f3a5c3b
to
13e8138
Compare
Sorry that i didn't have time before. Took a look now, looks great. But, for the example of let's say
I think I would want to keep the subfolder as well (molecules, set1, set2) and possibly the extension, if they're different for different files. I think the IDs could be, in this case,
what do you think? With the current implementation, i get the subfolders and extensions removed. What i propose is to just remove any common folders/files from front or back of the path (based on splitting on forwardslash). and potentially also removing extension, if common for all the files. Do you see any issues with this? |
Blocked by #54
Addresses suggestions in #53:
immutable_id
used to store current path-based ID format