Add support for named groups #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that the failing tests are not related to this PR. |
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 151 186 +35
Branches 46 56 +10
=====================================
+ Hits 151 186 +35
Continue to review full report at Codecov.
|
mathiasbynens
requested changes
May 12, 2018
rewrite-pattern.js
Outdated
| groups.names[name] = index; | ||
| if (groups.onNamedGroup) { | ||
| // Indirect call is needed to not leak 'groups' | ||
| (0, groups.onNamedGroup)(name, index); |
There was a problem hiding this comment.
Huh? This feels a little magical…
nicolo-ribaudo
force-pushed
the
named-groups
branch
from
49aa21d to
aae9459
Compare
|
Rebased |
mathiasbynens
approved these changes
May 14, 2018
|
Thanks for your contribution, @nicolo-ribaudo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs a new version ofregjsparserto be released (I usedyarn linklocally).Also, I have a question: what should these regexs be transformed to?I just had to read the spec 🙂/\k<name>/,/(?<name>)(?<name>)\k<name>