Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing before \vcenter, \vtop, \vbox. (mathjax/MathJax#3085) #990

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Aug 15, 2023

This PR fixes the spacing before \vcenter, \vtop, and \vbox macros. The problem was that the previous element's class wasn't being properly recorded, so nob spacing was being computed for it (the TeX spacing is based on the TeX classes of adjacent pairs of nodes).

Resolves issue mathjax/MathJax#3085

@dpvc dpvc requested a review from zorkow August 15, 2023 15:24
@dpvc dpvc added this to the v4.0 milestone Aug 15, 2023
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 2032f22 into develop Aug 17, 2023
@dpvc dpvc deleted the issue3085 branch August 17, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants