Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mardizzone/hotfix (POS-623) #114

Merged
merged 8 commits into from
Nov 18, 2022
Merged

mardizzone/hotfix (POS-623) #114

merged 8 commits into from
Nov 18, 2022

Conversation

marcello33
Copy link
Contributor

Description

Since bor sprint size changes have been merged into develop branch, this PR provides a way to run devnets with node v16.x.
This is achieved by modifying matic-cli to be able to check out commits instead of branches only (as per https://polygon.atlassian.net/browse/POS-623).

PLEASE NOTE:
This way devnets won't run sprint size changes
To run bor on develop branch, you can use the configs defined in bor-ci (matic-cli on branch arpit/pos-655-2 and contracts on branch jc/v0.3.1-backport) BUT you'll be using node v10.

Configs and env settings (changed in yaml, .env and README) will be restored once https://polygon.atlassian.net/browse/POS-979 is solved and PRs are merged back.

Changes

  • Hotfix (non-breaking change that solves an urgent issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

@marcello33 marcello33 merged commit 819df1d into master Nov 18, 2022
@marcello33 marcello33 deleted the mardizzone/hotfix branch November 18, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants