-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: add: aws-actions for ci / configs validation / eslint and prettier / global refactoring #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcello33
force-pushed
the
mardizzone/pos-1028
branch
from
December 7, 2022 07:25
3035766
to
89d5b12
Compare
marcello33
changed the title
dev: chg: use aws-actions to configure aws credentials
dev: chg: use aws-actions to configure aws credentials / add eslint and fix all errors-warning
Dec 13, 2022
…to mardizzone/pos-1028
marcello33
changed the title
dev: chg: use aws-actions to configure aws credentials / add eslint and fix all errors-warning
dev: add: aws-actions for ci / configs validation / eslint and prettier / global refactoring
Dec 15, 2022
0xsharma
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Raneet10
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is meant for the following things:
aws-actions
to setup the credentials to deploy EC2 instances usingopen id connect
. The ci will create a dedicated nodes network, execute the remote setup usingexpress-cli
and perform smoke tests to ensure everything works at every push or PR created. Thecontinue-on-error
will be removed once DevOps enablematic-cli
repo to useoidc
provider (thus enabling the ci to remotely deploy on users behalf).eslint
andprettier
into the ci and fail on warnings and errors.fail-fast
approach via user configuration validation, so that whenever the--start
command is triggered,express-cli
will run a sort ofdry-run
to ensure remotematic-cli
won't fail at a later stage.prettier
andeslint
, remove unused code, unifyganache-start
scripts, remove pleonastic templates...)aws sso
process for tokens expiration.Changes
Checklist
Testing