Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add: aws-actions for ci / configs validation / eslint and prettier / global refactoring #129

Merged
merged 28 commits into from
Dec 19, 2022

Conversation

marcello33
Copy link
Contributor

@marcello33 marcello33 commented Dec 6, 2022

Description

This PR is meant for the following things:

  • Configure the ci to use aws-actions to setup the credentials to deploy EC2 instances using open id connect. The ci will create a dedicated nodes network, execute the remote setup using express-cli and perform smoke tests to ensure everything works at every push or PR created. The continue-on-error will be removed once DevOps enable matic-cli repo to use oidc provider (thus enabling the ci to remotely deploy on users behalf).
  • Add eslint and prettier into the ci and fail on warnings and errors.
  • Introduce fail-fast approach via user configuration validation, so that whenever the --start command is triggered, express-cli will run a sort of dry-run to ensure remote matic-cli won't fail at a later stage.
  • Refactor and cleanup the whole code (fix warning and errors due to prettier and eslint, remove unused code, unify ganache-start scripts, remove pleonastic templates...)
  • Add additional documentation related to aws sso process for tokens expiration.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

@marcello33 marcello33 changed the title dev: chg: use aws-actions to configure aws credentials dev: chg: use aws-actions to configure aws credentials / add eslint and fix all errors-warning Dec 13, 2022
@marcello33 marcello33 changed the title dev: chg: use aws-actions to configure aws credentials / add eslint and fix all errors-warning dev: add: aws-actions for ci / configs validation / eslint and prettier / global refactoring Dec 15, 2022
@marcello33 marcello33 requested a review from a team December 15, 2022 07:28
@marcello33 marcello33 marked this pull request as ready for review December 15, 2022 07:30
Copy link
Contributor

@0xsharma 0xsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcello33 marcello33 merged commit ea77b7d into master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants