Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: chg: POS-1627: change default AWS region for deployments #190

Merged
merged 1 commit into from
Jul 11, 2023
Merged

dev: chg: POS-1627: change default AWS region for deployments #190

merged 1 commit into from
Jul 11, 2023

Conversation

marcello33
Copy link
Contributor

Description

Change default region for AWS deployment

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

Raneet10
Raneet10 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@Raneet10 Raneet10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcello33 marcello33 merged commit 30b01d8 into master Jul 11, 2023
@marcello33 marcello33 deleted the mardizzone/POS-1627 branch November 16, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikspatil024 pratikspatil024 pratikspatil024 approved these changes

@Raneet10 Raneet10 Raneet10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcello33 @Raneet10 @pratikspatil024