feat: bump to latest node 18 and allow unlimited contract size on rootchain #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leovct
changed the title
StakeManagerTestable contract
leovct
force-pushed
the
fix/deploy-stake-manager-testable
branch
from
bcef3c8 to
b362763
Compare
leovct
commented
Dec 4, 2023
marcello33
force-pushed
the
fix/deploy-stake-manager-testable
branch
from
ba923c4 to
b362763
Compare
gatsbyz
force-pushed
the
fix/deploy-stake-manager-testable
branch
from
1ccc9c7 to
9d5d160
Compare
gatsbyz
force-pushed
the
fix/deploy-stake-manager-testable
branch
3 times, most recently
from
dd65d1a to
26f482a
Compare
gatsbyz
force-pushed
the
fix/deploy-stake-manager-testable
branch
from
7d1aaf3 to
bf27ba2
Compare
leovct
changed the title
StakeManagerTestable contractStakeManagerTestable contract
leovct
commented
Dec 6, 2023
marcello33
approved these changes
Dec 6, 2023
Co-authored-by: marcello33 <[email protected]>
leovct
changed the title
StakeManagerTestable contract
|
Fixed with a workaround for this issue |
cffls
approved these changes
Dec 7, 2023
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We merged latest changes from
maticnetwork/contractsintomardizzone/node-16(maticnetwork/contracts#490), the branch used to deploy matic contracts in the PoS setup ofmatic-cli.The problem is that it deploys a new contract
StakeManagerTestablewhich exhausts all the gas on deployment. I didn't find any problems with the contract, its dependencies and the constructors, so I allowed unlimited contract size deployment on L1 to solve the issue. It also requires updating from ganache7.5.0to7.7.0- which causes some esm issues, we're trying to fix the problem.Related ticket: https://polygon.atlassian.net/browse/DVT-1146
Other changes
esmwhich caused issues when trying to bump ganache version, thanks to @gatsbyz 🙏compile-none).Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Cross repository changes
It should never be the case...
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it