Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: --fund-ganache-accounts flag #217

Merged
merged 25 commits into from
Feb 13, 2024
Merged

Conversation

anshalshukla
Copy link
Contributor

Description

This flag can be used to send 10 eth to all the ganache accounts.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

It should never be the case...

  • This PR requires changes to bor
    • In case link the PR here:
  • This PR requires changes to heimdall
    • In case link the PR here:

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

Manual tests

I've tests it on local devnet and it works fine.

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@anshalshukla anshalshukla requested a review from a team December 21, 2023 07:26
src/express/commands/setup-datadog.js Show resolved Hide resolved
src/express/common/ganache-utils.js Outdated Show resolved Hide resolved
src/express/common/ganache-utils.js Outdated Show resolved Hide resolved
src/setup/devnet/index.js Show resolved Hide resolved
@marcello33
Copy link
Contributor

Also, please merge master back into this branch.
It could solve the integration tests already, otherwise there's an issue with fund-ganache-account itself.

fix:lint

test

lint

fix lint
@anshalshukla anshalshukla force-pushed the fund-ganache-accounts branch from 9444848 to 5013fb2 Compare February 9, 2024 17:28
@anshalshukla anshalshukla merged commit 90acc8c into master Feb 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants