style: SpoolSelectionDialog improvements #5
Conversation
Signed-off-by: Pedro Lamas <[email protected]>
| @@ -100,6 +109,9 @@ export default class AppDialog extends Vue { | |||
| @Prop({ type: Boolean }) | |||
| readonly noActions?: boolean | |||
|
|
|||
| @Prop({ type: Boolean }) | |||
| readonly titleShadow?: boolean | |||
There was a problem hiding this comment.
This is a bit of a hack to get the shadow mode, but it works, so....
| small | ||
| class="ms-1 my-1" |
There was a problem hiding this comment.
| small | |
| class="ms-1 my-1" | |
| class="mr-2" |
This feels a bit crammed, and I'm not sure if the button should be aligned with the search input box?
Before
After
There was a problem hiding this comment.
The only reason I used those values is because we use them all over the app (ex: the cameras menu in camera card)
There was a problem hiding this comment.
Regarding the alignment, can you check what is the difference on the file explorer card?
It should have have same issue I think...
There was a problem hiding this comment.
It uses the collapsable-card instead, and the button is aligned there:
There was a problem hiding this comment.
I've fixed it, the problem was the margin on the search box (mx-2versus ml-1 like on the FileSystemToolbar.vue)
| small | ||
| class="ms-1 my-1" |
There was a problem hiding this comment.
| small | |
| class="ms-1 my-1" | |
| class="mr-2" |
See above
Signed-off-by: Pedro Lamas <[email protected]>
|
I think I got all the margins covered now! As I said, the only reason I went with these values is that they match the values we are using elsewhere in the app, so I am just trying to keep consistency! |
There are a couple of minor styling issues, but I thought it would be best practice to send you a PR to your PR instead of directly merging the changes! 🙂