Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circular ref in base widget #116

Merged
merged 1 commit into from
May 17, 2023
Merged

Remove circular ref in base widget #116

merged 1 commit into from
May 17, 2023

Conversation

dstansby
Copy link
Member

This removes the circular reference we had to introduce to keep the figure canavas around long enough for pytest-mpl to do the image comparison. Part of fixing #109, but independent enough to be in its own PR.

@dstansby dstansby marked this pull request as ready for review May 17, 2023 13:23
@dstansby dstansby requested a review from ruaridhg May 17, 2023 13:23
ruaridhg
ruaridhg approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@ruaridhg ruaridhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruaridhg
Copy link
Collaborator

ruaridhg commented May 17, 2023 •
edited
Loading

Closes #95

@ruaridhg ruaridhg added this pull request to the merge queue May 17, 2023
Merged via the queue into matplotlib:main with commit 415a237 May 17, 2023
@dstansby dstansby deleted the begone-circular-ref branch May 17, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruaridhg ruaridhg ruaridhg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @ruaridhg