Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding 2D and 3D tests for histogram and slice widgets #118

Merged
merged 3 commits into from
May 18, 2023
Merged

Adding 2D and 3D tests for histogram and slice widgets #118

merged 3 commits into from
May 18, 2023

Conversation

ruaridhg
Copy link
Collaborator

Towards #117

@ruaridhg ruaridhg requested review from dstansby and samcunliffe May 17, 2023 15:23
@dstansby
Copy link
Member

Doesn't this need a base image adding for the new histogram test?

@dstansby dstansby added the Tests label May 18, 2023
dstansby
dstansby approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dstansby dstansby added this pull request to the merge queue May 18, 2023
Merged via the queue into matplotlib:main with commit a5d0f03 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

@samcunliffe samcunliffe Awaiting requested review from samcunliffe

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruaridhg @dstansby