Simplify logic for adding a single axes #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcunliffe
approved these changes
May 5, 2023
There was a problem hiding this comment.
Yep cool. It's now explicit that we're delegating responsibility for the axis to each widget (which wasn't super clear to me on first pass).
From a styling PoV, are you thinking we'll tweak apply_napari_colorscheme to be overrideable (like from a user-supplied stylesheet)?
| # changing color of axes background to transparent | ||
| self.canvas.figure.patch.set_facecolor("none") |
There was a problem hiding this comment.
The figure's facecolor doesn't need to be set?
No, it doesn't but I don't get why.
There was a problem hiding this comment.
It's already set in NapariMPLWidget.__init__()
I'm expecting it will eventually become mostly redundant and replaced by a style sheet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
figure()property toNapariMPLWidget, to replace the documented.figureattribute that actually never existed.add_single_axes()helper method toNapariMPLWidget, that automatically adds a single axes and styles it.NapariMPLWidgetis not responsible for adding Axes to the figure.