Don't rely on members to query if syncing user can post to room #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ara4n
reviewed
Sep 3, 2018
| if (power_levels_event) { | ||
| power_levels = power_levels_event.getContent(); | ||
| events_levels = power_levels.events || {}; | ||
|
|
||
| if (utils.isNumber(power_levels.state_default)) { | ||
| if (Number.isFinite(power_levels.state_default)) { |
There was a problem hiding this comment.
Better to use things that are now available in standard JS as opposed to rolling our own?
There was a problem hiding this comment.
There is another utils.isNumber below we should probably change for consistency
|
lgtm modulo one random q :) |
|
making changes to avoid looking up the member, don't merge yet. |
bwindels
force-pushed
the
bwindels/fixllroompermission
branch
from
d4ba869 to
4026ae0
Compare
|
ready for another look |
bwindels
changed the title
bwindels
force-pushed
the
bwindels/fixllroompermission
branch
from
4026ae0 to
0998436
Compare
dbkr
approved these changes
Sep 5, 2018
as this might not be known for the syncing user. instead, add a method to room which always knows the syncing user's membership
bwindels
force-pushed
the
bwindels/fixllroompermission
branch
from
0998436 to
8b00083
Compare
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Sep 6, 2018
This fixes the tests that broke with matrix-org/matrix-js-sdk#717 This is because of https://github.com/vector-im/riot-web/blob/master/test/app-tests/joining.js#L63 which prevents the DOM nodes from actually ending up in the DOM, even though the react components get rendered. This means that WillMount and WillUnmount are called, but not DidMount. Using WillMount is more symmertrical anyway since the resulting teardown code must be in WillUnmount (since there is no DidUnmount).
This was referenced Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by matrix-org/matrix-react-sdk#2145