Remove duplicate tooltip from user pills (#8512)

* Remove duplicate tooltip from user pills * Fix test
matrix-org · May 6, 2022 · 765a715 · 765a715
1 parent 99543a7
commit 765a715
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/src/components/views/elements/Pill.tsx b/src/components/views/elements/Pill.tsx
@@ -225,7 +225,7 @@ export default class Pill extends React.Component<IProps, IState> {
                     member.rawDisplayName = member.rawDisplayName || '';
                     linkText = member.rawDisplayName;
                     if (this.props.shouldShowPillAvatar) {
-                        avatar = <MemberAvatar member={member} width={16} height={16} aria-hidden="true" />;
+                        avatar = <MemberAvatar member={member} width={16} height={16} aria-hidden="true" hideTitle />;
                     }
                     pillClass = 'mx_UserPill';
                     href = null;

diff --git a/src/utils/WidgetUtils.ts b/src/utils/WidgetUtils.ts
@@ -29,7 +29,6 @@ import { MatrixClientPeg } from '../MatrixClientPeg';
 import SdkConfig from "../SdkConfig";
 import dis from '../dispatcher/dispatcher';
 import WidgetEchoStore from '../stores/WidgetEchoStore';
-import SettingsStore from "../settings/SettingsStore";
 import { IntegrationManagers } from "../integrations/IntegrationManagers";
 import { WidgetType } from "../widgets/WidgetType";
 import { Jitsi } from "../widgets/Jitsi";

diff --git a/test/components/views/messages/TextualBody-test.tsx b/test/components/views/messages/TextualBody-test.tsx
@@ -254,12 +254,7 @@ describe("<TextualBody />", () => {
             const wrapper = getComponent({ mxEvent: ev }, matrixClient);
             expect(wrapper.text()).toBe("Hey Member");
             const content = wrapper.find(".mx_EventTile_body");
-            expect(content.html()).toBe('<span class="mx_EventTile_body markdown-body" dir="auto">' +
-                'Hey <span>' +
-                '<a class="mx_Pill mx_UserPill">' +
-                '<img class="mx_BaseAvatar mx_BaseAvatar_image" src="mxc://avatar.url/image.png" ' +
-                'style="width: 16px; height: 16px;" title="@member:domain.bla" alt="" aria-hidden="true">Member</a>' +
-                '</span></span>');
+            expect(content.html()).toMatchSnapshot();
         });
 
         it("pills do not appear in code blocks", () => {

diff --git a/test/components/views/messages/__snapshots__/TextualBody-test.tsx.snap b/test/components/views/messages/__snapshots__/TextualBody-test.tsx.snap
@@ -13,3 +13,5 @@ exports[`<TextualBody /> renders formatted m.text correctly pills do not appear
 </code><span></span></pre><span class=\\"mx_EventTile_button mx_EventTile_copyButton \\"></span></div>
 </span>"
 `;
+
+exports[`<TextualBody /> renders formatted m.text correctly pills get injected correctly into the DOM 1`] = `"<span class=\\"mx_EventTile_body markdown-body\\" dir=\\"auto\\">Hey <span><a class=\\"mx_Pill mx_UserPill\\"><img class=\\"mx_BaseAvatar mx_BaseAvatar_image\\" src=\\"mxc://avatar.url/image.png\\" style=\\"width: 16px; height: 16px;\\" alt=\\"\\" aria-hidden=\\"true\\">Member</a></span></span>"`;