This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Checkout PR head for strict error checker #10112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johennes
requested review from
germain-gg and
t3chguy
and removed request for
germain-gg
Johennes
added
the
T-Task
|
Hm, I guess I'm not sure why the jobs are failing here. 🤔 Will need to look into this later. Making this a draft for now. |
|
@Johennes because you didn't run prettier. |
t3chguy
reviewed
Feb 8, 2023
Co-authored-by: Michael Telatynski <[email protected]>
t3chguy
approved these changes
Feb 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #10083 I currently have the issue that the typescript strict check fails complaining about violations in files that I didn't touch in the PR. I think this is because by default the
checkoutaction checks out the repository's default branch and then merges the PR branch into it before running the checks. This might be desirable in other contexts but I think for the strict mode checks we really just care about issues in files that the PR actually touched.This change is marked as an internal change (Task), so will not be included in the changelog.