Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Run screenshot tests daily, instead of on each commit #10426

Merged
merged 4 commits into from
Mar 23, 2023

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Mar 22, 2023


This change is marked as an internal change (Task), so will not be included in the changelog.

Instead, we will run it daily. This will reduce the number of Percy
tests we run each month.
@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 22, 2023
@andybalaam andybalaam changed the title Run Percy Daily Run screenshot tests daily, instead of on each commit Mar 22, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This heavily duplicates cypress.yaml - please make use of composite actions and/or reusable workflows otherwise when updating things we are likely to diverge them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was about to ask you about this :-)

@andybalaam andybalaam marked this pull request as ready for review March 23, 2023 09:16
@andybalaam andybalaam requested a review from a team as a code owner March 23, 2023 09:16
@andybalaam andybalaam requested a review from t3chguy March 23, 2023 09:16
@andybalaam
Copy link
Member Author

I ran this on my fork overnight and it kicked off the Cypress tests as expected. Those tests failed in the same way as the normal Cypress tests, so there is a decent chance this is doing what I hope it will do.

The part I am not sure about is github.event.workflow_run.event == 'schedule'. I can't find any docs that help me know for sure whether this will work. Maybe I could try a mini test of this part on a fork, or maybe we just merge it here and see whether it works...

@andybalaam andybalaam requested review from t3chguy and a team March 23, 2023 13:59
@andybalaam andybalaam merged commit 372c5e1 into develop Mar 23, 2023
@andybalaam andybalaam deleted the andybalaam/percy-daily branch March 23, 2023 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants